Clarify Vec::extend_from_slice doc#151057
Open
tbu- wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
JayanAXHF
added
the
A-docs
JayanAXHF
reviewed
Jan 13, 2026
tbu-
force-pushed
the
pr_doc_vec_extendfromslice
branch
from
74bc6c2 to
77a2782
Compare
JayanAXHF
added
the
C-enhancement
joboet
reviewed
Jan 22, 2026
tbu-
force-pushed
the
pr_doc_vec_extendfromslice
branch
from
77a2782 to
e82cec8
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Hmm, that fails the run. I guess I have to investigate a little more. |
Member
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
…from_slice` Remove the template parameter `T` from `SpecExtend`. It was previously only used to create a second trait hierarchy just for `Vec::extend_from_slice`. Calling `vec.extend(slice.iter().cloned())` now calls the same code thanks to specialization. I don't know of any plans to deprecate this method.
tbu-
force-pushed
the
pr_doc_vec_extendfromslice
branch
from
e82cec8 to
034a149
Compare
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
vec.extend(slice.iter().cloned())calls the same code thanks to specialization.I don't know of any plans to deprecate this method.