Skip to content

Update triagebot config for compiler-errors, tests/{run-make,run-make-cargo} and fallback adhoc_group#150568

Merged
bors merged 3 commits intorust-lang:mainfrom
jieyouxu:triagebot-updates
Jan 2, 2026
Merged

Update triagebot config for compiler-errors, tests/{run-make,run-make-cargo} and fallback adhoc_group#150568
bors merged 3 commits intorust-lang:mainfrom
jieyouxu:triagebot-updates

Conversation

@jieyouxu
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu commented Jan 1, 2026

  • Commit 1: Updates triagebot entries for compiler-errors (context: Remove myself from more teams team#2205)
  • Commit 2: Expand tests/{run-make,run-make-cargo} reviewer pool to the compiler adhoc_group instead of just me for weighting reasons, so I don't become the sole assigned reviewer even when I'm off rotation.
  • Commit 3: Add myself to fallback adhoc_group so there's n > 1 pool there, in case one of the reviewers go off rotation.

Since they became alumni and don't want to receive pings anymore.
…e-cargo}` to `compiler`

So that I don't become the only automatically-assigned reviewer due to
weighting reasons.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 1, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 1, 2026

Mark-Simulacrum is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 1, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
Copy link
Copy Markdown
Member Author

jieyouxu commented Jan 1, 2026

r? compiler

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 1, 2026
@rustbot rustbot assigned mati865 and unassigned Mark-Simulacrum Jan 1, 2026
So that there's `n > 1` selection pool in case one of the eligible
reviewers go off rotation.
@jieyouxu jieyouxu changed the title Update triagebot config for compiler-errors and tests/{run-make,run-make-cargo} Update triagebot config for compiler-errors, tests/{run-make,run-make-cargo} and fallback adhoc_group Jan 1, 2026
Copy link
Copy Markdown
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Jan 1, 2026

@bors r+ rollup

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 1, 2026

📌 Commit f716d6c has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@Kivooeo Kivooeo assigned Kivooeo and unassigned mati865 Jan 1, 2026
bors added a commit that referenced this pull request Jan 1, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150382 (Tweak wording of diff marker diagnostic)
 - #150431 (test and document that `proc_macro::Ident` is NFC-normalized)
 - #150504 (Add regression test for issue #99173)
 - #150568 (Update triagebot config for `compiler-errors`, `tests/{run-make,run-make-cargo}` and `fallback` adhoc_group)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ecee483 into rust-lang:main Jan 2, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 2, 2026
Rollup merge of #150568 - jieyouxu:triagebot-updates, r=Kivooeo

Update triagebot config for `compiler-errors`, `tests/{run-make,run-make-cargo}` and `fallback` adhoc_group

- Commit 1: Updates triagebot entries for `compiler-errors` (context: rust-lang/team#2205)
- Commit 2: Expand `tests/{run-make,run-make-cargo}` reviewer pool to the `compiler` `adhoc_group` instead of just me for weighting reasons, so I don't become the sole assigned reviewer even when I'm off rotation.
- Commit 3: Add myself to `fallback` adhoc_group so there's `n > 1` pool there, in case one of the reviewers go off rotation.
@rustbot rustbot added this to the 1.94.0 milestone Jan 2, 2026
@jieyouxu jieyouxu deleted the triagebot-updates branch January 2, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants