test and document that proc_macro::Ident is NFC-normalized#150431
Merged
bors merged 1 commit intorust-lang:mainfrom Jan 2, 2026
Merged
test and document that proc_macro::Ident is NFC-normalized#150431bors merged 1 commit intorust-lang:mainfrom
proc_macro::Ident is NFC-normalized#150431bors merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
nnethercote
approved these changes
Jan 1, 2026
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 1, 2026
…uwer Rollup of 4 pull requests Successful merges: - #150382 (Tweak wording of diff marker diagnostic) - #150431 (test and document that `proc_macro::Ident` is NFC-normalized) - #150504 (Add regression test for issue #99173) - #150568 (Update triagebot config for `compiler-errors`, `tests/{run-make,run-make-cargo}` and `fallback` adhoc_group) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 2, 2026
Rollup merge of #150431 - cyrgani:nfc-proc-macro-test, r=nnethercote test and document that `proc_macro::Ident` is NFC-normalized Previously, this was not tested at all and the test suite would pass even when replacing the `normalize_and_validate_ident` implementation with a `panic!`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this was not tested at all and the test suite would pass even when replacing the
normalize_and_validate_identimplementation with apanic!.