Skip to content

Port #[rustc_never_returns_null_ptr] to attribute parser #150086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 17, 2025
Merged

Port #[rustc_never_returns_null_ptr] to attribute parser #150086

bors merged 1 commit into from
Dec 17, 2025
+28 −8

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Dec 17, 2025

Ports #[rustc_never_returns_null_ptr] to be parsed using the attribute parser

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2025
JonathanBrouwer
JonathanBrouwer reviewed Dec 17, 2025
View reviewed changes
@Bryntet Bryntet force-pushed the parse_never_return_null_pointer branch from f1f83e2 to 5692064 Compare December 17, 2025 11:35
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 17, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 17, 2025

📌 Commit 5692064 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 17, 2025
Merged
bors added a commit that referenced this pull request Dec 17, 2025
@bors
Auto merge of #150089 - JonathanBrouwer:rollup-9nmxze1, r=JonathanBro…
68f11a1 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150008 (Implement va_arg for Hexagon targets)
 - #150044 (Avoid unhelpful suggestion when crate name is invalid)
 - #150086 (Port `#[rustc_never_returns_null_ptr]` to attribute parser)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 84d441f into rust-lang:main Dec 17, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 17, 2025
@rust-timer
Unrolled build for #150086
d3c7f80 
Rollup merge of #150086 - Bryntet:parse_never_return_null_pointer, r=JonathanBrouwer

Port `#[rustc_never_returns_null_ptr]` to attribute parser

Ports `#[rustc_never_returns_null_ptr]` to be parsed using the attribute parser

r? `@JonathanBrouwer`
@rustbot rustbot added this to the 1.94.0 milestone Dec 17, 2025
@jdonszelmann jdonszelmann mentioned this pull request Dec 18, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer Awaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Bryntet @rustbot @JonathanBrouwer @bors