Skip to content

Comments

Add more unbounded_sh[lr] examples#150011

Merged
bors merged 1 commit intorust-lang:mainfrom
scottmcm:more-unbounded-shift-docs
Dec 29, 2025
Merged

Add more unbounded_sh[lr] examples#150011
bors merged 1 commit intorust-lang:mainfrom
scottmcm:more-unbounded-shift-docs

Conversation

@scottmcm
Copy link
Member

@scottmcm scottmcm commented Dec 15, 2025 •
edited by rustbot
Loading

Inspired by #149837, which added more stuff to wrapping_sh[lr], including a cross-reference to these methods.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

scottmcm
scottmcm commented Dec 15, 2025
View reviewed changes
library/core/src/num/int_macros.rs
@@ -1421,8 +1421,15 @@ macro_rules! int_impl {
/// # Examples
///
/// ```
#[doc = concat!("assert_eq!(0x1", stringify!($SelfT), ".unbounded_shl(4), 0x10);")]
#[doc = concat!("assert_eq!(0x1", stringify!($SelfT), ".unbounded_shl(129), 0);")]
#[doc = concat!("assert_eq!(0x1_", stringify!($SelfT), ".unbounded_shl(4), 0x10);")]
Copy link
Member Author

@scottmcm scottmcm Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annot: I use the _ in them because that pattern helps catch mistakes via https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes (and I think it helps readability too).

scottmcm
scottmcm commented Dec 15, 2025
View reviewed changes
library/core/src/num/uint_macros.rs
Comment on lines +1888 to +1889
#[doc = concat!("assert_eq!(42_", stringify!($SelfT), ".unbounded_shl(", stringify!($BITS), "), 0);")]
#[doc = concat!("assert_eq!(42_", stringify!($SelfT), ".unbounded_shl(1).unbounded_shl(", stringify!($BITS_MINUS_ONE), "), 0);")]
Copy link
Member Author

@scottmcm scottmcm Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annot: these are here to contrast with the equivalent ones from https://github.com/rust-lang/rust/pull/149837/changes#diff-b9390ee807a1dae3c3128dce36df56748ad8d23c6e361c0ebba4d744bf6efdb9R2618-R2619

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Dec 28, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 28, 2025

📌 Commit 242e58e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 28, 2025
Merged
bors added a commit that referenced this pull request Dec 28, 2025
@bors
Auto merge of #150469 - JonathanBrouwer:rollup-6ujkn6v, r=JonathanBro…
7fefa09 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #148321 (parser/lexer: bump to Unicode 17, use faster unicode-ident)
 - #149540 (std: sys: fs: uefi: Implement readdir)
 - #149582 (Implement `Duration::div_duration_{floor,ceil}`)
 - #149663 (Optimized implementation for uN::{gather,scatter}_bits)
 - #149667 (Fix ICE by rejecting const blocks in patterns during AST lowering (closes #148138))
 - #149947 (add several older crashtests)
 - #150011 (Add more `unbounded_sh[lr]` examples)
 - #150411 (refactor `destructure_const`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 13633c5 into rust-lang:main Dec 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 29, 2025
rust-timer added a commit that referenced this pull request Dec 29, 2025
@rust-timer
Unrolled build for #150011
3b0431b 
Rollup merge of #150011 - scottmcm:more-unbounded-shift-docs, r=Mark-Simulacrum

Add more `unbounded_sh[lr]` examples

Inspired by #149837, which added more stuff to `wrapping_sh[lr]`, including a cross-reference to these methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@scottmcm @rustbot @Mark-Simulacrum @bors