Add suggest alternatives for Out-of-range \x escapes #149201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Member
|
The two-notes approach looks reasonable to me in the same error, but I really don't know anything about this part of the compiler so I'm going to reroll, sorry. |
Kivooeo
reviewed
Nov 22, 2025
chenyukang
force-pushed
the
fix-str-format
branch
from
fd040b7 to
02bc55a
Compare
Member
|
I'm not 100% sure about note here, it feels to me that help would be better, because we are trying to help user to fix their incorrect code but I can be wrong about when to use each so correct me here |
chenyukang
force-pushed
the
fix-str-format
branch
from
02bc55a to
0f695f7
Compare
Member
Author
I'm neutral for |
Kivooeo
reviewed
Nov 23, 2025
chenyukang
force-pushed
the
fix-str-format
branch
from
0f695f7 to
9661d39
Compare
chenyukang
force-pushed
the
fix-str-format
branch
from
9661d39 to
4d4f315
Compare
Kivooeo
approved these changes
Nov 24, 2025
Member
|
r=me when ci green |
Member
Author
|
@bors r=Kivooeo |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 24, 2025
Rollup of 6 pull requests Successful merges: - #148234 (rustdoc: make mergeable crate info more usable) - #149201 (Add suggest alternatives for Out-of-range \x escapes) - #149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls) - #149252 (miri: use `tikv-jemalloc-sys` from sysroot) - #149255 (Use `let...else` consistently in user-facing diagnostics) - #149275 (Fix missing double-quote in `std::env::consts::OS` values) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 25, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#148234 (rustdoc: make mergeable crate info more usable) - rust-lang/rust#149201 (Add suggest alternatives for Out-of-range \x escapes) - rust-lang/rust#149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls) - rust-lang/rust#149252 (miri: use `tikv-jemalloc-sys` from sysroot) - rust-lang/rust#149255 (Use `let...else` consistently in user-facing diagnostics) - rust-lang/rust#149275 (Fix missing double-quote in `std::env::consts::OS` values) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Nov 27, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#148234 (rustdoc: make mergeable crate info more usable) - rust-lang/rust#149201 (Add suggest alternatives for Out-of-range \x escapes) - rust-lang/rust#149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls) - rust-lang/rust#149252 (miri: use `tikv-jemalloc-sys` from sysroot) - rust-lang/rust#149255 (Use `let...else` consistently in user-facing diagnostics) - rust-lang/rust#149275 (Fix missing double-quote in `std::env::consts::OS` values) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148917
seems add two notes seems better.
r? @scottmcm