Skip to content

Comments

Update wasm-related dependencies in CI#149037

Merged
bors merged 1 commit intorust-lang:mainfrom
alexcrichton:update-wasi-sdk
Nov 19, 2025
Merged

Update wasm-related dependencies in CI#149037
bors merged 1 commit intorust-lang:mainfrom
alexcrichton:update-wasi-sdk

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Nov 17, 2025 •
edited by rustbot
Loading

  • Update to wasi-sdk-29 released today
  • Update to Wasmtime 38.0.4 which was released a week or so ago

This is the same as #148611, except with wasi-sdk-29 to fixup some issues found in wasi-sdk-28.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
Copy link
Member

jieyouxu commented Nov 17, 2025

r? me @bors r+

@bors
Copy link
Collaborator

bors commented Nov 17, 2025

📌 Commit cafa424 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Nov 17, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025
bors added a commit that referenced this pull request Nov 18, 2025
@bors
Auto merge of #149037 - alexcrichton:update-wasi-sdk, r=jieyouxu
7fc15b4 
Update wasm-related dependencies in CI

* Update to wasi-sdk-29 released today
* Update to Wasmtime 38.0.4 which was released a week or so ago

This is the same as #148611, except with wasi-sdk-29 to fixup some issues found in wasi-sdk-28.
@bors
Copy link
Collaborator

bors commented Nov 18, 2025

⌛ Testing commit cafa424 with merge 7fc15b4...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Nov 18, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Nov 18, 2025

Hm, maybe networking?
@bors rollup=never
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
@alexcrichton
Update wasm-related dependencies in CI
4c6e41c 
* Update to wasi-sdk-29 released today
* Update to Wasmtime 38.0.4 which was released a week or so ago
@alexcrichton
Copy link
Member Author

alexcrichton commented Nov 18, 2025

Oh oops no that's a typo on my part, replaced one version but not the other...

@bors: r=jieyouxu

@bors
Copy link
Collaborator

bors commented Nov 18, 2025

📌 Commit 4c6e41c has been approved by jieyouxu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

⌛ Testing commit 4c6e41c with merge a591113...

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing a591113 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 19, 2025
@bors bors merged commit a591113 into rust-lang:main Nov 19, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6159a44 (parent) -> a591113 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a591113c0a2b7755514c47bde211fdb92d1d7002 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 2060.2s -> 1713.8s (-16.8%)
  2. dist-apple-various: 4598.6s -> 3834.0s (-16.6%)
  3. aarch64-apple: 8755.7s -> 7545.2s (-13.8%)
  4. x86_64-rust-for-linux: 2989.7s -> 2633.8s (-11.9%)
  5. i686-gnu-2: 6237.1s -> 5500.6s (-11.8%)
  6. armhf-gnu: 5565.8s -> 4914.1s (-11.7%)
  7. x86_64-gnu-llvm-20: 2839.6s -> 2517.3s (-11.3%)
  8. x86_64-gnu-llvm-20-2: 6362.6s -> 5649.5s (-11.2%)
  9. x86_64-gnu-aux: 7281.3s -> 6510.2s (-10.6%)
  10. aarch64-gnu-llvm-20-2: 2354.3s -> 2122.8s (-9.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 19, 2025

Finished benchmarking commit (a591113): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 0.5% [0.2%, 0.9%] 9
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) -1.2% [-2.8%, 0.4%] 2

Max RSS (memory usage)

Results (secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.8% [4.8%, 4.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.7%, secondary 4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.7% [4.7%, 4.7%] 1
Improvements ✅
(primary)		 -2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Bootstrap: 473.45s -> 472.582s (-0.18%)
Artifact size: 388.78 MiB -> 388.75 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Nov 19, 2025
@lqd
Copy link
Member

lqd commented Nov 19, 2025

Gotta be noise. A bunch of the changes are benchmarks returning to their previous state, fixing a spurious win.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 19, 2025
@tgross35 tgross35 mentioned this pull request Nov 20, 2025
Closed
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#149037 - alexcrichton:update-wasi-sdk, r=jiey…
8e8ec59 
…ouxu

Update wasm-related dependencies in CI

* Update to wasi-sdk-29 released today
* Update to Wasmtime 38.0.4 which was released a week or so ago

This is the same as rust-lang#148611, except with wasi-sdk-29 to fixup some issues found in wasi-sdk-28.
@jieyouxu jieyouxu mentioned this pull request Feb 6, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
@bors
Auto merge of #152183 - alexcrichton:update-wasi-sdk, r=jieyouxu
55bfca7 
Update wasi-sdk used in CI/releases

This is similar to prior updates such as #149037 in that this is just updating a URL. This update though has some technical updates accompanying it as well, however:

* The `wasm32-wasip2` target no longer uses APIs from WASIp1 on this target, even for startup. This means that the final binary no longer has an "adapter" which can help making instantiation of a component a bit more lean.

* In #147572 libstd was updated to use wasi-libc more often on the `wasm32-wasip2` target. This uncovered a number of bugs in wasi-libc such as #149864, #150291, and #151016. These are all fixed in wasi-sdk-30 so the workarounds in the standard library are all removed.

Overall this is not expected to have any sort of major impact on users of WASI targets. Instead it's expected to be a normal routine update to keep the wheels greased and oiled.
@alexcrichton alexcrichton mentioned this pull request Feb 6, 2026
Closed
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 13, 2026
@bors
Auto merge of #152183 - alexcrichton:update-wasi-sdk, r=jieyouxu
2dac8ff 
Update wasi-sdk used in CI/releases

This is similar to prior updates such as rust-lang/rust#149037 in that this is just updating a URL. This update though has some technical updates accompanying it as well, however:

* The `wasm32-wasip2` target no longer uses APIs from WASIp1 on this target, even for startup. This means that the final binary no longer has an "adapter" which can help making instantiation of a component a bit more lean.

* In rust-lang/rust#147572 libstd was updated to use wasi-libc more often on the `wasm32-wasip2` target. This uncovered a number of bugs in wasi-libc such as rust-lang/rust#149864, rust-lang/rust#150291, and rust-lang/rust#151016. These are all fixed in wasi-sdk-30 so the workarounds in the standard library are all removed.

Overall this is not expected to have any sort of major impact on users of WASI targets. Instead it's expected to be a normal routine update to keep the wheels greased and oiled.
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Feb 16, 2026
@bors
Auto merge of #152183 - alexcrichton:update-wasi-sdk, r=jieyouxu
c281532 
Update wasi-sdk used in CI/releases

This is similar to prior updates such as rust-lang/rust#149037 in that this is just updating a URL. This update though has some technical updates accompanying it as well, however:

* The `wasm32-wasip2` target no longer uses APIs from WASIp1 on this target, even for startup. This means that the final binary no longer has an "adapter" which can help making instantiation of a component a bit more lean.

* In rust-lang/rust#147572 libstd was updated to use wasi-libc more often on the `wasm32-wasip2` target. This uncovered a number of bugs in wasi-libc such as rust-lang/rust#149864, rust-lang/rust#150291, and rust-lang/rust#151016. These are all fixed in wasi-sdk-30 so the workarounds in the standard library are all removed.

Overall this is not expected to have any sort of major impact on users of WASI targets. Instead it's expected to be a normal routine update to keep the wheels greased and oiled.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 16, 2026
@bors
Auto merge of #152183 - alexcrichton:update-wasi-sdk, r=jieyouxu
f862a61 
Update wasi-sdk used in CI/releases

This is similar to prior updates such as rust-lang/rust#149037 in that this is just updating a URL. This update though has some technical updates accompanying it as well, however:

* The `wasm32-wasip2` target no longer uses APIs from WASIp1 on this target, even for startup. This means that the final binary no longer has an "adapter" which can help making instantiation of a component a bit more lean.

* In rust-lang/rust#147572 libstd was updated to use wasi-libc more often on the `wasm32-wasip2` target. This uncovered a number of bugs in wasi-libc such as rust-lang/rust#149864, rust-lang/rust#150291, and rust-lang/rust#151016. These are all fixed in wasi-sdk-30 so the workarounds in the standard library are all removed.

Overall this is not expected to have any sort of major impact on users of WASI targets. Instead it's expected to be a normal routine update to keep the wheels greased and oiled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

8 participants

@alexcrichton @rustbot @jieyouxu @bors @rust-log-analyzer @rust-timer @lqd @Mark-Simulacrum