-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Tweak Motor OS linker preset, fix remote-test-server for Motor OS
#148999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These commits modify compiler targets. |
Collaborator
This comment has been minimized.
This comment has been minimized.
Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).
85f8f33 to
02770b3
Compare
Member
remote-test-server for Motor OS
jieyouxu
approved these changes
Nov 17, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks fine to me
Member
|
@bors r+ rollup |
Collaborator
Member
|
(I edited your PR title, because the more significant change is changing the compiler target linker preset, not |
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 11 pull requests Successful merges: - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148752 (Constify `ManuallyDrop::take`) - #148757 (Constify `mem::take`) - #148855 (Error if an autodiff user does not set lto=fat) - #148912 (add note to `lines` docs about empty str behavior) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #148994 (Abi compatibility test cleanup) - #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) - #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup merge of #148999 - moturus:remote-test-server, r=jieyouxu Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Nov 17, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations) - rust-lang/rust#148752 (Constify `ManuallyDrop::take`) - rust-lang/rust#148757 (Constify `mem::take`) - rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat) - rust-lang/rust#148912 (add note to `lines` docs about empty str behavior) - rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI) - rust-lang/rust#148994 (Abi compatibility test cleanup) - rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion) - rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML) - rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
Rollup of 11 pull requests Successful merges: - rust-lang#148505 (add larger test for `proc_macro` `FromStr` implementations) - rust-lang#148752 (Constify `ManuallyDrop::take`) - rust-lang#148757 (Constify `mem::take`) - rust-lang#148855 (Error if an autodiff user does not set lto=fat) - rust-lang#148912 (add note to `lines` docs about empty str behavior) - rust-lang#148958 (Run codegen tests on a 32-bit target in PR CI) - rust-lang#148994 (Abi compatibility test cleanup) - rust-lang#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - rust-lang#149004 (compiletest: Avoid race condition in file deletion) - rust-lang#149008 (triagebot: remove jsha from notifications for rustdoc HTML) - rust-lang#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
O-motor-os
Operating system: Motor OS, https://doc.rust-lang.org/nightly/rustc/platform-support/motor.html
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).