Skip to content

dangling pointer from temp cleanup #148490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 15, 2025
Merged

dangling pointer from temp cleanup #148490

bors merged 1 commit into from
Dec 15, 2025

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Nov 4, 2025 •
edited
Loading

Continuation of #148348
r? @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot assigned Urgau and unassigned lcnr Nov 4, 2025
Urgau
Urgau reviewed Nov 4, 2025
View reviewed changes
@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
@hkBst
Copy link
Member Author

hkBst commented Nov 5, 2025

BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels

Should probably change a lot of these helps to notes...

@rust-cloud-vms rust-cloud-vms bot force-pushed the dangling-ptr-lint-2 branch from 0ef89d7 to 09188da Compare November 5, 2025 14:11
@hkBst
Copy link
Member Author

hkBst commented Nov 5, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2025
@rust-cloud-vms rust-cloud-vms bot force-pushed the dangling-ptr-lint-2 branch from 09188da to 9fb5a03 Compare November 7, 2025 10:54
Urgau
Urgau reviewed Nov 7, 2025
View reviewed changes
compiler/rustc_lint/messages.ftl Outdated
.note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
.note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>
lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
Copy link
Member

@Urgau Urgau Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?

dangling pointer created because {$ty} temporary is dropped at end of statement

Copy link
Member Author

@hkBst hkBst Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?

Copy link
Member

@Urgau Urgau Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.

Copy link
Member Author

@hkBst hkBst Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@rust-cloud-vms rust-cloud-vms bot force-pushed the dangling-ptr-lint-2 branch 2 times, most recently from cf34e89 to 6d9c94c Compare November 28, 2025 12:22
@hkBst
Copy link
Member Author

hkBst commented Nov 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the dangling-ptr-lint-2 branch from 6d9c94c to 7606f4d Compare November 28, 2025 15:19
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2025
@rust-cloud-vms rust-cloud-vms bot force-pushed the dangling-ptr-lint-2 branch from 7606f4d to cab9114 Compare December 14, 2025 11:39
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2025

⚠️ Warning ⚠️

@Urgau
Copy link
Member

Urgau commented Dec 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 14, 2025

📌 Commit cab9114 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#148490 - hkBst:dangling-ptr-lint-2, r=Urgau
768fefc 
dangling pointer from temp cleanup

Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#148490 - hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25 
dangling pointer from temp cleanup

Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2025
Closed
@hkBst
Copy link
Member Author

hkBst commented Dec 14, 2025

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2025
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of #149993 - matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8 
Rollup of 7 pull requests

Successful merges:

 - #146794 (std: reorganize pipe implementations)
 - #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
 - #148490 (dangling pointer from temp cleanup)
 - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
 - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
 - #149949 (Cleanup of attribute parsing errors)
 - #149969 (don't use no_main and no_core to test IBT)

Failed merges:

 - #148847 (Share Timespec between Unix and Hermit)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2025
Merged
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2 
Rollup of 8 pull requests

Successful merges:

 - #146794 (std: reorganize pipe implementations)
 - #148490 (dangling pointer from temp cleanup)
 - #149837 (Update `wrapping_sh[lr]` docs and examples)
 - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
 - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
 - #149949 (Cleanup of attribute parsing errors)
 - #149969 (don't use no_main and no_core to test IBT)
 - #149998 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 15, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e 
Rollup of 8 pull requests

Successful merges:

 - #146794 (std: reorganize pipe implementations)
 - #148490 (dangling pointer from temp cleanup)
 - #149837 (Update `wrapping_sh[lr]` docs and examples)
 - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
 - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
 - #149949 (Cleanup of attribute parsing errors)
 - #149969 (don't use no_main and no_core to test IBT)
 - #149998 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d7a18fc into rust-lang:main Dec 15, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2025
@rustbot rustbot added this to the 1.94.0 milestone Dec 15, 2025
rust-timer added a commit that referenced this pull request Dec 15, 2025
@rust-timer
Unrolled build for #148490
3626059 
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau

dangling pointer from temp cleanup

Continuation of #148348
r? `@Urgau`
@hkBst hkBst deleted the dangling-ptr-lint-2 branch December 15, 2025 09:02
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9 
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#146794 (std: reorganize pipe implementations)
 - rust-lang/rust#148490 (dangling pointer from temp cleanup)
 - rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
 - rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
 - rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
 - rust-lang/rust#149949 (Cleanup of attribute parsing errors)
 - rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
 - rust-lang/rust#149998 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst @rustbot @rust-log-analyzer @Urgau @bors @lcnr