r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Does the assembly contain calls to copy_within or to memmove? #[inline] will only help in the first case, not the second. In general, if LLVM decides to use memmove, that's mostly the right call – at least on GNU/Linux, memmove takes advantage of the SIMD features of the current CPU, which can end up being much faster than an unrolled implementation that can only use the CPU features of the target.

Does the assembly contain calls to copy_within or to memmove? #[inline] will only help in the first case, not the second. In general, if LLVM decides to use memmove, that's mostly the right call – at least on GNU/Linux, memmove takes advantage of the SIMD features of the current CPU, which can end up being much faster than an unrolled implementation that can only use the CPU features of the target.

It contains calls to memmove. Inlining will also help in this case, because without inlining llvm looses the fixed size information.
LLVM will replace calls to memmove with custom assembly in trivial cases, since e.g. a 8 byte copy is already faster than the libc function call.

Here's an example for both cases, the fixed 18bytes version does not contain a call to memmove:
https://godbolt.org/z/1xz7Gevbd

If your assembly does not include calls to copy_within, then this seems unlikely to help. It's also not that important because as a generic function, it's already eligible for inlining, so the attribute merely slightly adjusts heuristics. Have you checked that this PR helps?

@rustbot author

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@PSeitz Hi, ping from triage team. This PR has been inactive for a while. Are there any updates on this? Thanks

If your assembly does not include calls to copy_within, then this seems unlikely to help. It's also not that important because as a generic function, it's already eligible for inlining, so the attribute merely slightly adjusts heuristics. Have you checked that this PR helps?

Yes, I've seen that the memmov call disappeared with this change. I'm not sure why though, since we have generics on this function. I think maybe because of the inline it gets inlined in an earlier pass and the fixed value is propagated.