Add codegen-llvm regression tests #145380

okaneco · 2025-08-14T05:28:47Z

Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM.

closes #141497
closes #131162
closes #129583
closes #110971
closes #91109
closes #80075
closes #74917
closes #71997
closes #71257
closes #59352

rustbot · 2025-08-14T05:28:51Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Mark-Simulacrum · 2025-08-21T01:47:06Z

tests/codegen-llvm/issues/matches-logical-or-141497.rs

+// CHECK-LABEL: @is_inter_or_switch
+#[no_mangle]
+pub fn is_inter_or_switch(f: FrameType) -> bool {
+    // CHECK-NOT: ADD


This feels a little brittle -- maybe we should check a more specific sequence of instructions? Or some other form of assertion that's not "no adds".

Sure, I can change this to the specific sequence of checking and-cmp-ret in addition to the check-not.

This was the IR change from that issue, the subtraction being unwanted.

define i1 @src(i8 range(i8 0, 4) %arg) { - %add = add nsw i8 %arg, -1 %and = and i8 %add, -3 %cmp = icmp eq i8 %and, 0 ret i1 %cmp }

Mark-Simulacrum · 2025-08-21T01:48:57Z

tests/codegen-llvm/issues/vec-clear-unnecessary-branch-45459.rs

+#[no_mangle]
+pub fn check_no_compare(v: &mut Vec<f32>) {
+    // CHECK-NOT: icmp
+    // CHECK-NOT: br


This also seems brittle -- I could see a future compiler making this just call Vec::clear (given that the code sequence is the same for all 4-byte vec values, and maybe even for all T: Copy vec values?).

I'm not sure what to do so I'll back this test out then.

1.29 codegen - https://rust.godbolt.org/z/9qcPPMh67
1.30 codegen - https://rust.godbolt.org/z/7qK1rojYG

Most of these regressions concern elimination of panics and bounds checks that were fixed upstream by LLVM.

okaneco · 2025-08-21T04:17:39Z

I removed the vec clear test and that issue from the PR message.
I made the other test an explicit sequence instead of no additions.

@rustbot ready

Mark-Simulacrum · 2025-08-22T13:10:05Z

@bors r+ rollup=iffy

bors · 2025-08-22T13:10:08Z

📌 Commit 9e28de2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…Simulacrum Add codegen-llvm regression tests Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM. closes rust-lang#141497 closes rust-lang#131162 closes rust-lang#129583 closes rust-lang#110971 closes rust-lang#91109 closes rust-lang#80075 closes rust-lang#74917 closes rust-lang#71997 closes rust-lang#71257 closes rust-lang#59352

Rollup of 20 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144443 (Make target pointer width in target json an integer) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) Failed merges: - #145670 (port `sanitize` attribute to the new parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 28 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #137457 (Fix host code appearing in Wasm binaries) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145633 (Fix some typos in LocalKey documentation) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145742 (rustdoc js: Even more typechecking improvments ) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) - #145747 (Refactor lint buffering to avoid requiring a giant enum) - #145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set) - #145761 (Add aarch64_be-unknown-hermit target) - #145762 (convert strings to symbols in attr diagnostics) - #145763 (Ship LLVM tools for the correct target when cross-compiling) - #145765 (Revert suggestions for missing methods in tuples) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145380 - okaneco:add-codegen-tests, r=Mark-Simulacrum Add codegen-llvm regression tests Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM. closes #141497 closes #131162 closes #129583 closes #110971 closes #91109 closes #80075 closes #74917 closes #71997 closes #71257 closes #59352

Rollup of 28 pull requests Successful merges: - rust-lang/rust#132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - rust-lang/rust#137396 (Recover `param: Ty = EXPR`) - rust-lang/rust#137457 (Fix host code appearing in Wasm binaries) - rust-lang/rust#142185 (Convert moves of references to copies in ReferencePropagation) - rust-lang/rust#144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - rust-lang/rust#144897 (print raw lifetime idents with r#) - rust-lang/rust#145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - rust-lang/rust#145380 (Add codegen-llvm regression tests) - rust-lang/rust#145573 (Add an experimental unsafe(force_target_feature) attribute.) - rust-lang/rust#145597 (resolve: Remove `ScopeSet::Late`) - rust-lang/rust#145633 (Fix some typos in LocalKey documentation) - rust-lang/rust#145641 (On E0277, point at type that doesn't implement bound) - rust-lang/rust#145669 (rustdoc-search: GUI tests check for `//` in URL) - rust-lang/rust#145695 (Introduce ProjectionElem::try_map.) - rust-lang/rust#145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - rust-lang/rust#145726 (Experiment: Reborrow trait) - rust-lang/rust#145731 (Make raw pointers work in type-based search) - rust-lang/rust#145736 (triagebot: Update style team reviewers) - rust-lang/rust#145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - rust-lang/rust#145742 (rustdoc js: Even more typechecking improvments ) - rust-lang/rust#145743 (doc: fix some typos in comment) - rust-lang/rust#145745 (tests: Ignore basic-stepping.rs on LoongArch) - rust-lang/rust#145747 (Refactor lint buffering to avoid requiring a giant enum) - rust-lang/rust#145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set) - rust-lang/rust#145761 (Add aarch64_be-unknown-hermit target) - rust-lang/rust#145762 (convert strings to symbols in attr diagnostics) - rust-lang/rust#145763 (Ship LLVM tools for the correct target when cross-compiling) - rust-lang/rust#145765 (Revert suggestions for missing methods in tuples) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Aug 14, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2025

Mark-Simulacrum requested changes Aug 21, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025

Add codegen regression tests

9e28de2

Most of these regressions concern elimination of panics and bounds checks that were fixed upstream by LLVM.

okaneco force-pushed the add-codegen-tests branch from b109232 to 9e28de2 Compare August 21, 2025 02:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2025

jhpratt mentioned this pull request Aug 22, 2025

Rollup of 20 pull requests #145764

Closed

jhpratt mentioned this pull request Aug 23, 2025

Rollup of 28 pull requests #145773

Merged

bors merged commit f0a4148 into rust-lang:master Aug 23, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 23, 2025

okaneco deleted the add-codegen-tests branch August 23, 2025 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add codegen-llvm regression tests #145380

Add codegen-llvm regression tests #145380

Uh oh!

okaneco commented Aug 14, 2025 •

edited

Loading

Uh oh!

rustbot commented Aug 14, 2025

Uh oh!

Mark-Simulacrum Aug 21, 2025

Uh oh!

okaneco Aug 21, 2025

Uh oh!

Mark-Simulacrum Aug 21, 2025

Uh oh!

okaneco Aug 21, 2025

Uh oh!

okaneco commented Aug 21, 2025

Uh oh!

Mark-Simulacrum commented Aug 22, 2025

Uh oh!

bors commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Add codegen-llvm regression tests #145380

Add codegen-llvm regression tests #145380

Uh oh!

Conversation

okaneco commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 14, 2025

Uh oh!

Mark-Simulacrum Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

okaneco Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

okaneco Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

okaneco commented Aug 21, 2025

Uh oh!

Mark-Simulacrum commented Aug 22, 2025

Uh oh!

bors commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

okaneco commented Aug 14, 2025 •

edited

Loading