Skip to content

tests/ui/issues/: The Issues Strike Back [1/N]#144151

Merged
bors merged 2 commits into
rust-lang:masterfrom
Kivooeo:issue1
Jul 28, 2025
Merged

tests/ui/issues/: The Issues Strike Back [1/N]#144151
bors merged 2 commits into
rust-lang:masterfrom
Kivooeo:issue1

Conversation

@Kivooeo

@Kivooeo Kivooeo commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I believe I’ve finally brought my program to life -- it now handles multiple test moves in one go: plain moves first, then a gentle touch on each file depends on given options. The process should be much smoother now.

Of course, I won’t rush through everything in a few days -- that would be unkind to @Oneirical. I’ll pace myself. And also I can't have more than one such PR because issues.txt will conflict with previous parts after merging them which is not fun as well.

This PR is just that: first commit - moves; second - regression comments and the occasional .stderr reblesses, also issue.txt and tidy changes. Nothing special, but progress nonetheless. This is for the purpose of preserving test file history during restructuring

Part of #133895.

r? @jieyouxu

@rustbot

rustbot commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2025
@rustbot

rustbot commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

There are changes to the tidy tool.

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo changed the title tests/ui/issues/: The Part Where I Reorganize You [1/N] tests/ui/issues/: The Issues Strike Back [1/N] Jul 18, 2025
@asquared31415

asquared31415 commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

I have not been following this very much, but that's amazing that there's already been over 150 tests removed from the issues.txt exceptions! And thank you for your work on improving the test situation and the tool you made seems very helpful!

@bors

bors commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #144360) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu
jieyouxu requested changes Jul 24, 2025
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some nits.

Re. naming for these issues tests, I think it's actually better to still include the test number (not the substring issue of course) unless there's a very descriptive and specific test name.

Test names like *-type-error or *-error or *-behavior are super generic, and since they're not the kind of "foundational" test coverage (where you intentionally "build up" systematic test coverage for something), they would IMO benefit from having the issue number for more context upfront.

Comment thread tests/ui/array-slice-vec/array-pattern-matching.rs
Comment thread tests/ui/array-slice-vec/trait-object-arrays.rs
Comment thread tests/ui/closures/fnonce-closure-call.rs
Comment thread tests/ui/drop/conditional-drop-behavior.rs
Comment thread tests/ui/drop/trait-object-drop-behavior.rs
Comment thread tests/ui/traits/missing-trait-method-error.rs
Comment thread tests/ui/traits/negative-positive-impl-conflict.rs
Comment thread tests/ui/type-alias/mismatched-rc-foo-types.rs
Comment thread src/tools/tidy/src/issues.txt
Comment thread tests/ui/parser/comment-parsing.rs
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2025
@Kivooeo

Kivooeo commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Next PRs imo should be general better, but only thing is I didn't used issue numbers anywhere, this is most problem I see for now. I will address this problem in the future

@jieyouxu

jieyouxu commented Jul 24, 2025

Copy link
Copy Markdown
Member

That's fine :)

@rustbot

rustbot commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@Kivooeo

Kivooeo commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

It'll fail because of stray .stderr files, very soon

@jieyouxu

jieyouxu commented Jul 24, 2025

Copy link
Copy Markdown
Member

No rush :) It's 🛏️ time for me, so I'll re-review another time.

@Kivooeo

Kivooeo commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

There also will be a PR after I finish with this one where I rename all directories with _ as separator to - for consistency

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo

Kivooeo commented Jul 24, 2025

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2025
jieyouxu
jieyouxu reviewed Jul 25, 2025
View reviewed changes
Comment thread tests/ui/SUMMARY.md

@jieyouxu jieyouxu Jul 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this will merge conflict with #144340.

@Kivooeo Kivooeo Jul 25, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until it's merged then I'll fix conflict and we are good, also I'm going to revise other parts names, to add issue numbers at some generic names

Comment thread tests/ui/borrowck/closure-borrow-conflict.rs
Comment thread tests/ui/cfg/conditional-compilation-struct.rs
Comment thread tests/ui/coercion/trait-object-arrays.rs
Comment thread tests/ui/diagnostics-infra/primary-fluent-bundle-missing.rs
Comment thread tests/ui/lifetimes/container-lifetime-error.rs
Comment thread tests/ui/lifetimes/keyword-self-lifetime-error.rs
Comment thread tests/ui/structs/mutable-unit-struct-borrow.rs
Comment thread tests/ui/traits/blanket-impl-trait-object.rs
Comment thread tests/ui/type-alias/static-method-type-alias.rs
@jieyouxu

jieyouxu commented Jul 25, 2025

Copy link
Copy Markdown
Member

Hm yeah, some of these test names are IMO still too generic, that they really could use the issue number for more TL;DR context.
@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2025
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 25, 2025
@rustbot

rustbot commented Jul 25, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Kivooeo Kivooeo force-pushed the issue1 branch 2 times, most recently from 3453826 to 2ee2a2f Compare July 25, 2025 10:07
@jieyouxu

jieyouxu commented Jul 25, 2025

Copy link
Copy Markdown
Member

@rustbot blocked (on #144340)

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2025
@bors

bors commented Jul 25, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #144440) made this pull request unmergeable. Please resolve the merge conflicts.

@Kivooeo

Kivooeo commented Jul 25, 2025

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 25, 2025
@Kivooeo Kivooeo mentioned this pull request Jul 25, 2025
Merged
jieyouxu
jieyouxu approved these changes Jul 28, 2025
View reviewed changes

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu

jieyouxu commented Jul 28, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit e9959aa has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 28, 2025
Merged
bors added a commit that referenced this pull request Jul 28, 2025
@bors
Auto merge of #144562 - matthiaskrgr:rollup-mlvn7qo, r=matthiaskrgr
65b6cdb 
Rollup of 7 pull requests

Successful merges:

 - #144072 (update `Atomic*::from_ptr` and `Atomic*::as_ptr` docs)
 - #144151 (`tests/ui/issues/`: The Issues Strike Back [1/N])
 - #144300 (Clippy fixes for miropt-test-tools)
 - #144399 (Add a ratchet for moving all standard library tests to separate packages)
 - #144472 (str: Mark unstable `round_char_boundary` feature functions as const)
 - #144503 (Various refactors to the codegen coordinator code (part 3))
 - #144530 (coverage: Infer `instances_used` from `pgo_func_name_var_map`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a08ced3 into rust-lang:master Jul 28, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 28, 2025
rust-timer added a commit that referenced this pull request Jul 28, 2025
@rust-timer
Unrolled build for #144151
60798d6 
Rollup merge of #144151 - Kivooeo:issue1, r=jieyouxu

`tests/ui/issues/`: The Issues Strike Back [1/N]

I believe I’ve finally brought [my program](https://github.com/Kivooeo/test-manager) to life -- it now handles multiple test moves in one go: plain moves first, then a gentle touch on each file depends on given options. The process should be much smoother now.

Of course, I won’t rush through everything in a few days -- that would be unkind to `@Oneirical.` I’ll pace myself. And also I can't have more than one such PR because `issues.txt` will conflict with previous parts after merging them which is not fun as well.

This PR is just that: first commit - moves; second - regression comments and the occasional .stderr reblesses, also issue.txt and tidy changes. Nothing special, but progress nonetheless. This is for the purpose of preserving test file history during restructuring

Part of #133895.

r? `@jieyouxu`
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #144562 - matthiaskrgr:rollup-mlvn7qo, r=matthiaskrgr
f8fcf33 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#144072 (update `Atomic*::from_ptr` and `Atomic*::as_ptr` docs)
 - rust-lang/rust#144151 (`tests/ui/issues/`: The Issues Strike Back [1/N])
 - rust-lang/rust#144300 (Clippy fixes for miropt-test-tools)
 - rust-lang/rust#144399 (Add a ratchet for moving all standard library tests to separate packages)
 - rust-lang/rust#144472 (str: Mark unstable `round_char_boundary` feature functions as const)
 - rust-lang/rust#144503 (Various refactors to the codegen coordinator code (part 3))
 - rust-lang/rust#144530 (coverage: Infer `instances_used` from `pgo_func_name_var_map`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Kivooeo @rustbot @rust-log-analyzer @asquared31415 @bors @jieyouxu