Skip to content

rustc_allowed_through_unstable_modules: require deprecation message #136434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Feb 2, 2025
Merged

rustc_allowed_through_unstable_modules: require deprecation message #136434

bors merged 1 commit into from
Feb 2, 2025

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 2, 2025

This changes the #[rustc_allowed_through_unstable_modules] attribute so that a deprecation message (ideally directing people towards the stable path) is required.

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

@RalfJung RalfJung force-pushed the rustc_allowed_through_unstable_modules-deprecation-required branch from 55bb0d9 to 3320e91 Compare February 2, 2025 11:36
@compiler-errors
Copy link
Member

compiler-errors commented Feb 2, 2025

r? compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Feb 2, 2025

📌 Commit 3320e91 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#136434 - RalfJung:rustc_allowed_through_uns…
364a776 
…table_modules-deprecation-required, r=compiler-errors

rustc_allowed_through_unstable_modules: require deprecation message

This changes the `#[rustc_allowed_through_unstable_modules]` attribute so that a deprecation message (ideally directing people towards the stable path) is required.
This was referenced Feb 2, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025
@bors
Auto merge of rust-lang#136448 - matthiaskrgr:rollup-pdim5di, r=matth…
4a43094 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134272 (Remove rustc_encodable_decodable feature)
 - rust-lang#136283 (Update encode_utf16 to mention it is native endian)
 - rust-lang#136394 (Clean up MonoItem::instantiation_mode)
 - rust-lang#136402 (diagnostics: fix borrowck suggestions for if/while let conditionals)
 - rust-lang#136415 (Highlight clarifying information in "expected/found" error)
 - rust-lang#136422 (Convert two `rustc_middle::lint` functions to `Span` methods.)
 - rust-lang#136434 (rustc_allowed_through_unstable_modules: require deprecation message)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 961bf7f into rust-lang:master Feb 2, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025
@rust-timer
Unrolled build for rust-lang#136434
98393f5 
Rollup merge of rust-lang#136434 - RalfJung:rustc_allowed_through_unstable_modules-deprecation-required, r=compiler-errors

rustc_allowed_through_unstable_modules: require deprecation message

This changes the `#[rustc_allowed_through_unstable_modules]` attribute so that a deprecation message (ideally directing people towards the stable path) is required.
@rustbot rustbot added this to the 1.86.0 milestone Feb 2, 2025
@RalfJung RalfJung deleted the rustc_allowed_through_unstable_modules-deprecation-required branch February 3, 2025 11:02
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025