Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't check for overlap if it's allowed regardless #135524

Closed
wants to merge 2 commits into from
Closed

don't check for overlap if it's allowed regardless #135524

wants to merge 2 commits into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jan 15, 2025 •
edited
Loading

fixes #135457. I am not a big fan of this tbh, want to figure out why the proof tree visitor is so damn slow here.

There's some discussion of the underlying issue in https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/new-solver.20hang.20.23135457. Would like to chat about what to do there in sync 😁

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2025
@lcnr lcnr changed the title oh yeah :> the underlying issue is not fixed that way 😅 don't check for overlap if its allowed regardless Jan 15, 2025
@lcnr
Copy link
Contributor Author

lcnr commented Jan 15, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 15, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2025
@bors
Auto merge of rust-lang#135524 - lcnr:fix-hang, r=<try>
8d4ccf9 
don't check for overlap if its allowed regardless

fixes rust-lang#135457. I am not a big fan of this tbh, want to figure out why the proof tree visitor is so damn slow here.

r? `@compiler-errors`
@bors
Copy link
Collaborator

bors commented Jan 15, 2025

⌛ Trying commit aa75cc2 with merge 8d4ccf9...

@lcnr lcnr added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 15, 2025
@lcnr lcnr changed the title don't check for overlap if its allowed regardless don't check for overlap if it's allowed regardless Jan 15, 2025
@bors
Copy link
Collaborator

bors commented Jan 15, 2025

☀️ Try build successful - checks-actions
Build commit: 8d4ccf9 (8d4ccf93e57332735bba28dbedab29978029e7d4)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d4ccf9): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 4.1% [0.1%, 10.4%] 25
Regressions ❌
(secondary)		 0.2% [0.1%, 0.3%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.1% [0.1%, 10.4%] 25

Max RSS (memory usage)

Results (primary -1.1%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.7% [3.7%, 3.7%] 1
Improvements ✅
(primary)		 -1.1% [-2.6%, -0.5%] 6
Improvements ✅
(secondary)		 -1.9% [-2.8%, -1.0%] 2
All ❌✅ (primary) -1.1% [-2.6%, -0.5%] 6

Cycles

Results (primary 4.0%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.0% [2.7%, 6.5%] 13
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 4.0% [2.7%, 6.5%] 13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.182s -> 762.236s (-0.12%)
Artifact size: 326.01 MiB -> 326.03 MiB (0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 15, 2025
@lcnr lcnr mentioned this pull request Jan 17, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135618 - lcnr:coherence-unknown, r=<try>
1a372d6 
add cache to `AmbiguityCausesVisitor`

fixes rust-lang#135457, alternative to rust-lang#135524.

cc https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/new-solver.20hang.20.23135457

r? `@compiler-errors`
@lcnr lcnr closed this Jan 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135618 - lcnr:coherence-unknown, r=compiler-e…
8e59cf9 
…rrors

add cache to `AmbiguityCausesVisitor`

fixes rust-lang#135457, alternative to rust-lang#135524.

cc https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/new-solver.20hang.20.23135457

r? `@compiler-errors`
@apiraino
Copy link
Contributor

apiraino commented Jan 23, 2025 •
edited
Loading

I'll remove the backport nominations since it's superseded by #135618

@rustbot label -beta-nominated -stable-nominated

@rustbot rustbot removed beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation taking unexpected long after 1.84
6 participants
@lcnr @rust-timer @bors @apiraino @compiler-errors @rustbot