Skip to content

fix typo in typenames of pin documentation #135497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 16, 2025
Merged

fix typo in typenames of pin documentation #135497

bors merged 1 commit into from
Jan 16, 2025

Conversation

@RusticMaple
Copy link
Contributor

@RusticMaple RusticMaple commented Jan 14, 2025

I noticed this whilst reading the documentation for pin.

Basically there was just one to many closing angle brackets on the type parameters in the documentation where instead of being Pin<&mut T> it was Pin<&mut T>>

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jhpratt (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RusticMaple
Copy link
Contributor Author

RusticMaple commented Jan 14, 2025

whoops i think i accidentally inserted something by accident let me quickly fix that sorry

@compiler-errors
Copy link
Member

compiler-errors commented Jan 14, 2025

please squash this into one commit. i don't think we need that in the git history forever.

@compiler-errors
Copy link
Member

compiler-errors commented Jan 14, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2025
@RusticMaple
Copy link
Contributor Author

RusticMaple commented Jan 15, 2025

the commits are squashed into 1 commit now

@RusticMaple
Copy link
Contributor Author

RusticMaple commented Jan 15, 2025

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2025
@jhpratt
Copy link
Member

jhpratt commented Jan 15, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 15, 2025

📌 Commit b535a1d has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 15, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2025
@bors
Auto merge of rust-lang#135555 - matthiaskrgr:rollup-jnqdbuu, r=matth…
6fc8a27 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#135497 (fix typo in typenames of pin documentation)
 - rust-lang#135522 (add incremental test for issue 135514)
 - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense)
 - rust-lang#135535 (Add GUI test for rust-lang#135499)
 - rust-lang#135541 (Methods of const traits are const)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 85d2b2a into rust-lang:master Jan 16, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
@rust-timer
Unrolled build for rust-lang#135497
60f0086 
Rollup merge of rust-lang#135497 - DJMrTV:master, r=jhpratt

fix typo in typenames of pin documentation

I noticed this whilst reading the documentation for pin.

Basically there was just one to many closing angle brackets on the type parameters in the documentation where instead of being `Pin<&mut T>` it was `Pin<&mut T>>`
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025