Skip to content

Remove some unnecessary .into() calls #135269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 9, 2025
Merged

Remove some unnecessary .into() calls #135269

bors merged 1 commit into from
Jan 9, 2025

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Jan 8, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2025

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

compiler-errors
compiler-errors approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to separate your contributions between compiler/library in the future, esp if you're running clippy lints (which I assume this is just the fixes from useless_conversions), but this seems fine.

@compiler-errors
Copy link
Contributor

compiler-errors commented Jan 8, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 8, 2025

📌 Commit eb917ea has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 9, 2025
@jhpratt
Rollup merge of rust-lang#135269 - estebank:unneeded-into, r=compiler…
4807d81 
…-errors

Remove some unnecessary `.into()` calls
@jhpratt jhpratt mentioned this pull request Jan 9, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@bors
Auto merge of rust-lang#135279 - matthiaskrgr:rollup-ek2qere, r=matth…
ec12cd8 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#135212 (Remove outdated information in the `unreachable_pub` lint description)
 - rust-lang#135225 (Explicitly build proc macro test with panic=unwind)
 - rust-lang#135242 (add missing provenance APIs on NonNull)
 - rust-lang#135247 (Add a list of symbols for stable standard library crates)
 - rust-lang#135269 (Remove some unnecessary `.into()` calls)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@rust-timer
Unrolled build for rust-lang#135269
07b757e 
Rollup merge of rust-lang#135269 - estebank:unneeded-into, r=compiler-errors

Remove some unnecessary `.into()` calls
@bors bors merged commit a1cadea into rust-lang:master Jan 9, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 9, 2025
tautschnig added a commit to tautschnig/verify-rust-std that referenced this pull request Jan 17, 2025
@tautschnig