add comments in check_expr_field #134148
Merged
add comments in check_expr_field #134148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oriongonza
force-pushed
the
cleanup_check_field_expr
branch
from
58aadb8 to
66b68a8
Compare
This comment has been minimized.
This comment has been minimized.
oriongonza
force-pushed
the
cleanup_check_field_expr
branch
from
66b68a8 to
57f8271
Compare
| @@ -2748,6 +2761,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| _ => {} | |||
| } | |||
| } | |||
|
|
|||
| // We failed to check the expression, report an error. | |||
There was a problem hiding this comment.
This comment doesn't really describe what this is doing. It's attempting to emit an error if we end up derefing to an infer var, like calling .field on a base type of &_.
There was a problem hiding this comment.
That comment was more general, as in "ok we're no longer in the happy path"
There was a problem hiding this comment.
Well it's useful regardless to document the random structural resolve call. Pls do that :)
compiler-errors
approved these changes
Dec 11, 2024
|
Then r=me |
oriongonza
force-pushed
the
cleanup_check_field_expr
branch
from
57f8271 to
55806e5
Compare
|
@bors r=compiler-errors |
1 similar comment
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132975 (De-duplicate and improve definition of core::ffi::c_char) - rust-lang#133598 (Change `GetManyMutError` to match T-libs-api decision) - rust-lang#134148 (add comments in check_expr_field) - rust-lang#134163 (coverage: Rearrange the code for embedding per-function coverage metadata) - rust-lang#134165 (wasm(32|64): update alignment string) - rust-lang#134170 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
Rollup merge of rust-lang#134148 - dev-ardi:cleanup_check_field_expr, r=compiler-errors add comments in check_expr_field Nothing special, just a few comments and a couple of small cleanups.
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132975 (De-duplicate and improve definition of core::ffi::c_char) - rust-lang#133598 (Change `GetManyMutError` to match T-libs-api decision) - rust-lang#134148 (add comments in check_expr_field) - rust-lang#134163 (coverage: Rearrange the code for embedding per-function coverage metadata) - rust-lang#134165 (wasm(32|64): update alignment string) - rust-lang#134170 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing special, just a few comments and a couple of small cleanups.