Skip to content

Create UI test directory for CLI tests: tests/ui/cli/ #133277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmease wants to merge 1 commit into from
Closed

Create UI test directory for CLI tests: tests/ui/cli/ #133277

fmease wants to merge 1 commit into from

Conversation

@fmease
Copy link
Member

@fmease fmease commented Nov 21, 2024 •
edited
Loading

Split out of #127581 because it's slightly bitrotty.

  1. Generalizes tests/ui/invalid-compile-flags/ to tests/ui/cli/ for all sorts of CLI tests. Should help with discoverability (that's the main motivation).
  2. Tuck directory tests/ui/extern-flag/ (for everything --extern) into it
  3. Move need-crate-arg-ignore-tidy$x.rs out of tests/ui/command/ (for std::process::Command tests) and into tests/ui/cli/ where it belongs.

@fmease
Create UI test directory for CLI tests
123e97f 
Note that `need-crate-arg-ignore-tidy$x.rs` used to be in `tests/ui/command/`
which wasn't 'correct' as that directory concerns `std::process::Command` tests
not CLI tests.
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2024
@fmease fmease changed the title Create UI test directory for CLI tests Create UI test directory for CLI tests: tests/ui/cli/ Nov 21, 2024
@nnethercote
Copy link
Contributor

nnethercote commented Nov 21, 2024

We discussed on Zulip, cli is a very broad name and it's not really clear what tests would belong in it. invalid-compile-flags is much clearer.

@nnethercote nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024
@fmease fmease closed this Nov 21, 2024
@fmease fmease deleted the mkdir-tests-ui-cli branch November 21, 2024 03:16
@fmease fmease mentioned this pull request Dec 7, 2024
Merged
@fmease fmease mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fmease @rustbot @nnethercote