Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Make CoverageSuccessors a struct #132379

Closed
wants to merge 1 commit into from
Closed

coverage: Make CoverageSuccessors a struct #132379

wants to merge 1 commit into from

Conversation

Zalathar
Copy link
Contributor

A small and self-contained improvement, extracted from some larger things I'm working on.

There are two minor differences implied by this change:

  • A SwitchInt terminator with exactly one target is now eligible to be chained.
    • The previous behaviour didn't have any strong rationale, and this gets rid of a special case.
  • A terminator with no coverage-relevant successors is now always marked as “not out-summable”.
    • This is more correct, because (for example) a Return terminator has no successors (so their sum of execution counts is 0), but the return itself can have a non-zero execution count.
    • The existing code that checks this flag doesn't care either way, but this is likely to matter in the future.

There are no observable changes to the output of any of the coverage tests.

@Zalathar Zalathar added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Oct 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@Zalathar
Copy link
Contributor Author

Incorporated into #132389.

@Zalathar Zalathar closed this Oct 31, 2024
@Zalathar Zalathar mentioned this pull request Oct 31, 2024
Merged
@Zalathar Zalathar deleted the successors-struct branch November 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zalathar @rustbot @cjgillot