Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rustdoc-json-types): mark simple enums as copy #131976

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

jalil-salame
Copy link
Contributor

Fixes rust-lang/rustdoc-types#26 and some typos in the documentation

r? @aDotInTheVoid

I have been assigning these PRs to you @aDotInTheVoid, is that okay? I think I'm out of PRs for now, but for future reference c:

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 20, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2024

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@jalil-salame jalil-salame force-pushed the rustdoc-types-copy-enums branch from 0c7fdf4 to afa75f0 Compare October 20, 2024 17:01
@aDotInTheVoid
Copy link
Member

I have been assigning these PRs to you is that okay?

Yep! It's really helpful, thanks for doing it. Rustbot will make it's best guess about who to assign if you don't but I'm not in that review queue. I'll probably still review it if it's a rustdoc-json change, but it avoids pinging someone else unnecessarily.

@aDotInTheVoid
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 20, 2024

📌 Commit afa75f0 has been approved by aDotInTheVoid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 20, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#131814 (`optimize` attribute applied to things other than methods/functions/c…)
 - rust-lang#131927 (Check for filecheck directives in files marked `skip-filecheck`)
 - rust-lang#131967 (Remove `lower_mono_bounds`)
 - rust-lang#131973 (fix(rustdoc-json-types): document rustc-hash feature)
 - rust-lang#131976 (feat(rustdoc-json-types): mark simple enums as copy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b65865 into rust-lang:master Oct 21, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2024
Rollup merge of rust-lang#131976 - jalil-salame:rustdoc-types-copy-enums, r=aDotInTheVoid

feat(rustdoc-json-types): mark simple enums as copy

Fixes rust-lang/rustdoc-types#26 and some typos in the documentation

r? `@aDotInTheVoid`

I have been assigning these PRs to you `@aDotInTheVoid,` is that okay? I think I'm out of PRs for now, but for future reference c:
@rustbot rustbot added this to the 1.84.0 milestone Oct 21, 2024
@jalil-salame jalil-salame deleted the rustdoc-types-copy-enums branch October 21, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make simple enums copy
4 participants