Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lib): Enhance documentation for core::fmt::Formatter's write_fm… #129001

Merged
merged 2 commits into from
Aug 14, 2024
Merged

chore(lib): Enhance documentation for core::fmt::Formatter's write_fm… #129001

merged 2 commits into from
Aug 14, 2024

Conversation

cblh
Copy link
Contributor

@cblh cblh commented Aug 12, 2024

fix: #128713

@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2024

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 12, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cblh
Copy link
Contributor Author

cblh commented Aug 13, 2024

r? @Noratrieb

@rustbot rustbot assigned Noratrieb and unassigned scottmcm Aug 13, 2024
@Noratrieb
Copy link
Member

@bors r+ rollup

thanks!

@bors
Copy link
Collaborator

bors commented Aug 14, 2024

📌 Commit c433302 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2024
@bors
Auto merge of rust-lang#129076 - matthiaskrgr:rollup-rg8mi2x, r=matth…
9859bf2 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake)
 - rust-lang#128759 (alloc: add ToString specialization for `&&str`)
 - rust-lang#128873 (Add windows-targets crate to std's sysroot)
 - rust-lang#129001 (chore(lib): Enhance documentation for core::fmt::Formatter's write_fm…)
 - rust-lang#129061 (Use `is_lang_item` more)
 - rust-lang#129062 (Remove a no-longer-true assert)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a4261a0 into rust-lang:master Aug 14, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2024
@rust-timer
Unrolled build for rust-lang#129001
1b64609 
Rollup merge of rust-lang#129001 - cblh:fix/128713, r=Noratrieb

chore(lib): Enhance documentation for core::fmt::Formatter's write_fm…

fix: rust-lang#128713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

core::fmt::Formatter does not mention write! macro
6 participants
@cblh @rustbot @rust-log-analyzer @Noratrieb @bors @scottmcm