Hash Ipv*Addr as an integer #128946
Hash Ipv*Addr as an integer #128946
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This seems uncontroversial, but I'm still nominating this for T-libs to sign off on making the hash implementation behaviour be endian-independent. @rustbot label I-libs-nominated r=me after their OK |
rustbot
added
the
I-libs-nominated
|
We discussed this in today's libs meeting. Per https://doc.rust-lang.org/nightly/std/hash/trait.Hash.html#portability , there's no guarantee that Hash has the same result on different targets, so by all means do the most efficient thing, which is presumably @rfcbot r=joboet |
And notably unavoidable extra work due to arrays being Thus I think calling https://doc.rust-lang.org/std/hash/trait.Hash.html#method.hash_slice would also be sufficient, but the |
|
@bors r+ |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125970 (CommandExt::before_exec: deprecate safety in edition 2024) - rust-lang#127905 (Add powerpc-unknown-linux-muslspe compile target) - rust-lang#128925 (derive(SmartPointer): register helper attributes) - rust-lang#128946 (Hash Ipv*Addr as an integer) - rust-lang#128963 (Add possibility to generate rustdoc JSON output to stdout) - rust-lang#129015 (Update books) - rust-lang#129067 (Use `append` instead of `extend(drain(..))`) - rust-lang#129100 (Fix dependencies cron job) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125970 (CommandExt::before_exec: deprecate safety in edition 2024) - rust-lang#127905 (Add powerpc-unknown-linux-muslspe compile target) - rust-lang#128925 (derive(SmartPointer): register helper attributes) - rust-lang#128946 (Hash Ipv*Addr as an integer) - rust-lang#128963 (Add possibility to generate rustdoc JSON output to stdout) - rust-lang#129015 (Update books) - rust-lang#129067 (Use `append` instead of `extend(drain(..))`) - rust-lang#129100 (Fix dependencies cron job) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128946 - orlp:faster-ip-hash, r=joboet Hash Ipv*Addr as an integer The `Ipv4Addr` and `Ipv6Addr` structs always have a fixed size, but directly derive `Hash`. This causes them to call the bytestring hasher implementation, which adds extra work for most hashers. This PR converts the internal representation to a fixed-width integer before passing to the hasher to prevent this.
dtolnay
removed
the
I-libs-nominated
The
Ipv4AddrandIpv6Addrstructs always have a fixed size, but directly deriveHash. This causes them to call the bytestring hasher implementation, which adds extra work for most hashers. This PR converts the internal representation to a fixed-width integer before passing to the hasher to prevent this.