alloc: add ToString specialization for &&str
#128759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
|
it just keeps going... |
This comment has been minimized.
This comment has been minimized.
|
This seems to induce a diagnostic regression? |
The two altered expectation messages both seem like improvements: - `coerce-expect-unsized-ascribed.stderr` says you can go `Box<char> -> Box<dyn Debug>`, which you can. - `upcast_soundness_bug.stderr` used to say that you could go `Box<dyn Trait<u8, u8>> -> Box<dyn Trait>`, which you can't, because the type parameters are missing in the destination and the only ones that work aren't what's needed.
Yeah, it did. It seems like a bug in the actual diagnostics code, though. So I've added a second commit to address it. Should I open a second PR with just the one commit? |
|
It would probably be best if someone on T-compiler reviewed the diagnostics amendment so however you want to arrange for that to happen is fine by me (separate PR, pinging someone, whatevs). |
|
Okay, next commit is a slightly less complex version of the macro. Since there's only 12 impls, the self-recursion goes away entirely, and the other two helpers are separated out into their own macros. |
|
r? compiler |
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/spec-to-string
branch
from
ffa62b2 to
3312f5d
Compare
workingjubilee
approved these changes
Aug 12, 2024
compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs
Outdated
Show resolved
Hide resolved
This makes more things match, particularly applicable blankets.
notriddle
force-pushed
the
notriddle/spec-to-string
branch
from
b0af854 to
c6fb0f3
Compare
|
@bors r=workingjubilee,compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) - rust-lang#128759 (alloc: add ToString specialization for `&&str`) - rust-lang#128873 (Add windows-targets crate to std's sysroot) - rust-lang#129001 (chore(lib): Enhance documentation for core::fmt::Formatter's write_fm…) - rust-lang#129061 (Use `is_lang_item` more) - rust-lang#129062 (Remove a no-longer-true assert) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2024
Rollup merge of rust-lang#128759 - notriddle:notriddle/spec-to-string, r=workingjubilee,compiler-errors alloc: add ToString specialization for `&&str` Fixes rust-lang#128690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128690