rwlock: disable 'frob' test in Miri on macOS #128640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I'm split on this: On the one hand, I don't want people wasting time chasing down a known bug. But on the other hand, if there were another bug in the I'm leaving this up to you, r=me if you still think this is worth it. Otherwise, just the comment on the |
RalfJung
force-pushed
the
rwlock-macos-miri
branch
from
8f070fd to
a120fb7
Compare
|
Each time it fails it will cause confusion and whoever runs into it will lose a bunch of time figuring out what happens. It's not about CI times, it's about not wasting people's time with known issues. If another bug is introduced and it doesn't have such an insanely low rate of actually surfacing, we have other tests that will likely catch it. So yeah I think this is still worth it. |
|
@bors r=joboet |
bors
added
S-waiting-on-bors
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 8, 2024
rwlock: disable 'frob' test in Miri on macOS Due to rust-lang#121950, Miri will sometimes complain about this test on macOS. Better disable the test, as otherwise it can fail for unrelated PRs. r? `@joboet`
This was referenced Aug 8, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#128640 (rwlock: disable 'frob' test in Miri on macOS) - rust-lang#128791 (Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`) - rust-lang#128806 (Split `ColorConfig` off of `HumanReadableErrorType`) - rust-lang#128818 (std float tests: special-case Miri in feature detection) - rust-lang#128834 (rustdoc: strip unreachable modules) - rust-lang#128836 (rustdoc-json: add a test for impls on private & hidden types) - rust-lang#128837 (Clippy subtree update) - rust-lang#128851 (Add comment that bors did not see pushed before it merged) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
Rollup merge of rust-lang#128640 - RalfJung:rwlock-macos-miri, r=joboet rwlock: disable 'frob' test in Miri on macOS Due to rust-lang#121950, Miri will sometimes complain about this test on macOS. Better disable the test, as otherwise it can fail for unrelated PRs. r? ``@joboet``
This was referenced Nov 19, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 19, 2024
ignore an occasionally-failing test in Miri This is like rust-lang#128640, the test [sometimes](rust-lang#133189) fails due to rust-lang#121950.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2024
Rollup merge of rust-lang#133200 - RalfJung:miri-rwlock-test, r=tgross35 ignore an occasionally-failing test in Miri This is like rust-lang#128640, the test [sometimes](rust-lang#133189) fails due to rust-lang#121950.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 20, 2024
ignore an occasionally-failing test in Miri This is like rust-lang/rust#128640, the test [sometimes](rust-lang/rust#133189) fails due to rust-lang/rust#121950.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #121950, Miri will sometimes complain about this test on macOS. Better disable the test, as otherwise it can fail for unrelated PRs.
r? @joboet