Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate words #127230

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: remove duplicate words #127230

merged 1 commit into from
Jul 2, 2024

Conversation

hattizai
Copy link
Contributor

@hattizai hattizai commented Jul 2, 2024

remove duplicate words in comments to improve readability.

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nadrieril (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 2, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty minor, but the rustfmt team prefers if these kinds of changes be made directly to https://github.com/rust-lang/rustfmt. Could you revet these changes and open up a PR there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, reverted.

@ytmimi
Copy link
Contributor

ytmimi commented Jul 2, 2024

@hattizai instead of a new commit can you amend the history to remove the rustfmt change?

@hattizai
Copy link
Contributor Author

hattizai commented Jul 2, 2024

Done

@saethlin
Copy link
Member

saethlin commented Jul 2, 2024

It's always amazing to me how many of these mistakes people manage to dig up. I suppose we just keep checking them in! Thanks for the fixes.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 2, 2024

📌 Commit ada9fda has been approved by saethlin

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 2, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2024
@bors bors merged commit a10c231 into rust-lang:master Jul 2, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants