Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixme in core now that NonZero is generic #126904

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Small fixme in core now that NonZero is generic #126904

merged 1 commit into from
Jun 24, 2024

Conversation

GrigorenkoPV
Copy link
Contributor

I doubt I have the rights to, but
@bors rollup=always

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2024

r? @m-ou-se

rustbot has assigned @m-ou-se.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 24, 2024
@joboet
Copy link
Member

joboet commented Jun 24, 2024

Cool, thank you!
@bors r+ rollup
r? joboet

@bors
Copy link
Contributor

bors commented Jun 24, 2024

📌 Commit 84474a2 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2024
@compiler-errors compiler-errors mentioned this pull request Jun 24, 2024
Merged
@bors bors merged commit 85eb835 into rust-lang:master Jun 24, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 24, 2024
@GrigorenkoPV GrigorenkoPV deleted the nonzero-fixme branch June 25, 2024 08:20
@ivan-shrimp ivan-shrimp mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GrigorenkoPV @rustbot @joboet @bors @m-ou-se