LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc#122558
Conversation
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use r? to explicitly pick a reviewer |
| false || builder.build.unstable_features(), | ||
| |tools| { | ||
| tools.iter().any(|tool| match tool.as_ref() { | ||
| "clippy" => "llvm-bitcode-linker" == "clippy-driver", |
There was a problem hiding this comment.
This was an accident I guess
There was a problem hiding this comment.
This is expanded from the macro it previously was generated from. I don't know if it was important for something so I didn't dare to remove it.
Are you saying I should remove it?
There was a problem hiding this comment.
It should be indeed removed. "clippy" => "llvm-bitcode-linker" == "clippy-driver" has no purpose. Something like |tools| tools.iter().any(|tool| tool == "llvm-bitcode-linker") should be enough.
There was a problem hiding this comment.
I actually read the code now, and it is indeed meaningless. Should be fixed now
c64dea9 to
3c34cbe
Compare
|
@rustbot ready |
|
@bors r+ |
…_trigger_rebuild, r=onur-ozkan LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc fixes rust-lang#122491 `@rustbot` ready
|
@bors rollup=iffy |
| let bindir = builder.sysroot(self.compiler).join("bin"); | ||
| t!(fs::create_dir_all(&bindir)); | ||
| let bin_destination = bindir.join(exe(bin_name, self.compiler.host)); | ||
| builder.copy(&tool_out, &bin_destination); |
There was a problem hiding this comment.
This function no longer exists (since #122590) in the upstream. Can you rebase the PR and fix that?
|
@bors r- |
…he cache of rustdoc
3c34cbe to
7bdd63d
Compare
|
@rustbot ready |
|
@bors r+ |
…rigger_rebuild, r=onur-ozkan LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc fixes rust-lang#122491 `@rustbot` ready
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Finished benchmarking commit (13abc0a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.94s -> 668.532s (-0.06%) |
fixes #122491
@rustbot ready