Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf test] #120268 #122414

Closed
wants to merge 1 commit into from
Closed

[perf test] #120268 #122414

wants to merge 1 commit into from

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Mar 13, 2024

r? ghost

@dianqk
Revert "Auto merge of rust-lang#120268 - DianQK:otherwise_is_last_var…
272dd0b 
…iant_switchs, r=oli-obk"

This reverts commit 14fbc3c, reversing
changes made to 9fb91aa.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 13, 2024
@dianqk
Copy link
Member Author

dianqk commented Mar 13, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2024
@bors
Auto merge of rust-lang#122414 - DianQK:perf/test-120268, r=<try>
38b84c2 
[perf test] rust-lang#120268

r? ghost
@bors
Copy link
Contributor

bors commented Mar 13, 2024

⌛ Trying commit 272dd0b with merge 38b84c2...

@bors
Copy link
Contributor

bors commented Mar 13, 2024

☀️ Try build successful - checks-actions
Build commit: 38b84c2 (38b84c24f34fa6dbf2204891194f54f389e3b175)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38b84c2): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.6%, 1.1%] 6
Regressions ❌
(secondary)		 0.4% [0.3%, 0.7%] 16
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 2
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.2%] 6
All ❌✅ (primary) 0.5% [-0.5%, 1.1%] 8

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 5.3% [3.8%, 6.9%] 3
Regressions ❌
(secondary)		 4.3% [4.3%, 4.3%] 1
Improvements ✅
(primary)		 -8.1% [-10.1%, -5.5%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.4% [-10.1%, 6.9%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.8%] 41
Regressions ❌
(secondary)		 0.9% [0.0%, 1.6%] 33
Improvements ✅
(primary)		 -0.1% [-0.4%, -0.0%] 20
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.0%] 10
All ❌✅ (primary) 0.1% [-0.4%, 0.8%] 61

Bootstrap: 672.147s -> 673.649s (0.22%)
Artifact size: 310.26 MiB -> 310.23 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 13, 2024
@dianqk dianqk closed this Mar 13, 2024
@dianqk dianqk mentioned this pull request Mar 13, 2024
Merged
@dianqk dianqk deleted the perf/test-120268 branch August 12, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dianqk @rust-timer @bors @rustbot