Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip coroutines in jump threading to avoid query cycles #121133

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Skip coroutines in jump threading to avoid query cycles #121133

merged 1 commit into from
Feb 15, 2024

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 15, 2024

Fixes #121094

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 15, 2024

📌 Commit 5f4e4ba has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2024
@erickt
Copy link
Contributor

erickt commented Feb 15, 2024

Thanks for tracking down the bug!

@compiler-errors compiler-errors mentioned this pull request Feb 15, 2024
Closed
@tmandry
Copy link
Member

tmandry commented Feb 15, 2024

@bors p=1

@bors
Copy link
Collaborator

bors commented Feb 15, 2024

⌛ Testing commit 5f4e4ba with merge a447249...

@bors
Copy link
Collaborator

bors commented Feb 15, 2024

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing a447249 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2024
@bors bors merged commit a447249 into rust-lang:master Feb 15, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 15, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a447249): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.6% [-6.6%, -6.6%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.6% [-4.6%, -4.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 639.504s -> 637.914s (-0.25%)
Artifact size: 306.30 MiB -> 306.33 MiB (0.01%)

@tmiasko tmiasko deleted the skip-coroutines branch May 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

Recent optimization broke async recursion in release mode
8 participants
@tmiasko @rustbot @cjgillot @bors @erickt @tmandry @rust-timer @petrochenkov