Uplift `ClauseKind` and `PredicateKind` into `rustc_type_ir` by compiler-errors · Pull Request #116993 · rust-lang/rust

compiler-errors · 2023-10-20T20:47:31Z

Uplift ClauseKind and PredicateKind into rustc_type_ir.

Blocked on #116951

r? @ghost

rustbot · 2023-10-20T20:47:36Z

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

compiler-errors · 2023-10-20T20:49:04Z

    type T = stable_mir::ty::ClauseKind;

    fn stable(&self, tables: &mut Tables<'tcx>) -> Self::T {
-        use ty::ClauseKind::*;


SMIR: this glob import doesn't work anymore because we don't import variants when glob-importing from a type alias. I opted to just refer to these variants by their qualified name -- imo, it's also not that big of a deal, since we're literally doing the same thing for PredicateKind right above.

bors · 2023-10-21T00:13:26Z

☔ The latest upstream changes (presumably #116958) made this pull request unmergeable. Please resolve the merge conflicts.

jackh726 · 2023-10-22T21:32:43Z

@bors r+

bors · 2023-10-22T21:32:45Z

📌 Commit 573f475 has been approved by jackh726

It is now in the queue for this repository.

bors · 2023-10-25T05:02:07Z

⌛ Testing commit 573f475 with merge 98108dc...

bors · 2023-10-25T06:56:30Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 98108dc to master...

rust-timer · 2023-10-25T08:07:59Z

Finished benchmarking commit (98108dc): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.8%, -0.2%]	14
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.8%, -0.2%]	14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.8%	[5.1%, 7.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 304.40 MiB -> 304.45 MiB (0.02%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2023

compiler-errors commented Oct 20, 2023

View reviewed changes

compiler-errors changed the title ~~Clause kind~~ Uplift ClauseKind and PredicateKind into rustc_type_ir Oct 20, 2023

rust-cloud-vms Bot force-pushed the clause-kind branch from 07b67e6 to 71f721e Compare October 20, 2023 21:06

compiler-errors assigned jackh726 Oct 21, 2023

Uplift ClauseKind and PredicateKind

573f475

compiler-errors force-pushed the clause-kind branch from 71f721e to 573f475 Compare October 21, 2023 00:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2023

bors merged commit 98108dc into rust-lang:master Oct 25, 2023

rustbot added this to the 1.75.0 milestone Oct 25, 2023

bors mentioned this pull request Oct 25, 2023

Uplift Canonical to rustc_type_ir #117008

Merged

github-actions Bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

jackh726 mentioned this pull request Nov 30, 2023

Tracking issue for shared type library rust-lang/types-team#16

Open

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uplift `ClauseKind` and `PredicateKind` into `rustc_type_ir`#116993

Uplift `ClauseKind` and `PredicateKind` into `rustc_type_ir`#116993
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:clause-kind

compiler-errors commented Oct 20, 2023

Uh oh!

rustbot commented Oct 20, 2023

Uh oh!

compiler-errors Oct 20, 2023 •

edited

Loading

Uh oh!

bors commented Oct 21, 2023

Uh oh!

jackh726 commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

bors commented Oct 25, 2023

Uh oh!

bors commented Oct 25, 2023

Uh oh!

rust-timer commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

compiler-errors commented Oct 20, 2023

Uh oh!

rustbot commented Oct 20, 2023

Uh oh!

compiler-errors Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Oct 21, 2023

Uh oh!

jackh726 commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

bors commented Oct 25, 2023

Uh oh!

bors commented Oct 25, 2023

Uh oh!

rust-timer commented Oct 25, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

compiler-errors Oct 20, 2023 •

edited

Loading