On Windows make `read_dir` error on the empty path by ChrisDenton · Pull Request #116606 · rust-lang/rust

ChrisDenton · 2023-10-10T16:51:32Z

This makes Windows consistent with other platforms. Note that this should not be taken to imply any decision on #114149 has been taken. However it was felt that while there is a lack of libs-api consensus, we should be consistent across platforms in the meantime.

This is a change in behaviour for Windows so will also need an fcp before merging.

r? libs-api

ChrisDenton · 2023-10-22T12:37:30Z

FCP is now complete...

dtolnay

Thank you!

dtolnay · 2023-10-22T15:45:26Z

@bors r+

bors · 2023-10-22T15:45:28Z

📌 Commit 367d7ed has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-10-22T15:45:29Z

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

bors · 2023-10-23T05:38:36Z

⌛ Testing commit 367d7ed with merge aec4741...

bors · 2023-10-23T07:31:46Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing aec4741 to master...

rust-timer · 2023-10-23T08:43:08Z

Finished benchmarking commit (aec4741): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.8%	[3.8%, 3.8%]	1
Regressions ❌ (secondary)	4.7%	[4.7%, 4.7%]	1
Improvements ✅ (primary)	-3.6%	[-3.6%, -3.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-3.6%, 3.8%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 304.26 MiB -> 304.28 MiB (0.01%)

rustbot assigned dtolnay Oct 10, 2023

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 10, 2023

ChrisDenton changed the title ~~On Windows make readdir error on the empty path~~ On Windows make read_dir error on the empty path Oct 10, 2023

This comment has been minimized.

Sign in to view

On Windows make readdir error on the empty path

367d7ed

ChrisDenton force-pushed the empty branch from 01f025c to 367d7ed Compare October 10, 2023 16:57

Amanieu mentioned this pull request Oct 10, 2023

read_dir has unexpected behavior for "" #114149

Closed

dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023

dtolnay approved these changes Oct 22, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2023

bors merged commit aec4741 into rust-lang:master Oct 23, 2023

rustbot added this to the 1.75.0 milestone Oct 23, 2023

ChrisDenton deleted the empty branch October 23, 2023 07:47

github-actions Bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

matthiaskrgr mentioned this pull request Apr 16, 2024

ICE: node HirId ... cannot be placed in TypeckResults with hir_owner DefId... #124022

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

On Windows make `read_dir` error on the empty path#116606

On Windows make `read_dir` error on the empty path#116606
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:empty

ChrisDenton commented Oct 10, 2023 •

edited

Loading

Uh oh!

This comment has been minimized.

ChrisDenton commented Oct 22, 2023 •

edited

Loading

Uh oh!

dtolnay left a comment

Uh oh!

dtolnay commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

bors commented Oct 23, 2023

Uh oh!

bors commented Oct 23, 2023

Uh oh!

rust-timer commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ChrisDenton commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ChrisDenton commented Oct 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

bors commented Oct 23, 2023

Uh oh!

bors commented Oct 23, 2023

Uh oh!

rust-timer commented Oct 23, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ChrisDenton commented Oct 10, 2023 •

edited

Loading

ChrisDenton commented Oct 22, 2023 •

edited

Loading