non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound by fmease · Pull Request #116379 · rust-lang/rust

fmease · 2023-10-03T11:55:22Z

Opaque types like impl for<T> Trait<T> would previously lead to an ICE.

fmease · 2023-10-03T11:56:05Z

-            // Liberate bound regions in the predicate since we
-            // don't actually care about lifetimes in this check.
-            let predicate = cx.tcx.liberate_late_bound_regions(def_id, pred.kind());
+            let predicate = infcx.instantiate_binder_with_placeholders(


Not entirely sure if we should instantiate with fresh vars instead 😅

placeholders i guess are fine since we don't solve regions at all

fmease · 2023-10-03T11:58:29Z

I couldn't craft a test that involves non-lifetime binders & triggers opaque_hidden_inferred_bound since higher-ranked hidden types aren't supported yet. E.g., impl for<T> Trait<T, Assoc = Tait<T>> errors out early.

what does it error with?

(with -Zverbose)

error[E0792]: non-defining opaque type use in defining scope --> experiment.rs:21:28 | 21 | () -> impl for<T> Trait<T, Assoc = Tait<T>> { | ^^^^^^^^^^^^^^^ argument `^"T"` is not a generic parameter | note: for this opaque type --> experiment.rs:17:24 | 17 | type Tait<T: ?Sized> = impl Duh<T>; | ^^^^^^^^^^^ error[E0792]: expected generic type parameter, found `!1_"T"` --> experiment.rs:22:5 | 17 | type Tait<T: ?Sized> = impl Duh<T>; | - this generic parameter must be used with a generic type parameter ... 22 | 42 | ^^

oh oh right

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=4d06b9342a949d9adfa2d9a365dc5731

compiler-errors

r=me when green

matthiaskrgr · 2023-10-03T12:07:02Z

does this fix #108814 ?

fmease · 2023-10-03T12:10:23Z

Nope, it doesn't. This PR only fixes code containing opaque types with non-lifetime binders.

fmease · 2023-10-03T12:35:47Z

@bors r=compiler-errors

bors · 2023-10-03T12:35:49Z

📌 Commit 3f0a327 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#114654 (Suggest `pin!()` instead of `Pin::new()` when appropriate) - rust-lang#116261 (a small wf and clause cleanup) - rust-lang#116282 (Fix broken links) - rust-lang#116328 (Factor out common token generation in `fluent_messages`.) - rust-lang#116379 (non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116379 - fmease:opaq-hid-inf-bnds-non-lt-bndrs, r=compiler-errors non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound Opaque types like `impl for<T> Trait<T>` would previously lead to an ICE. r? `@compiler-errors`

rustbot assigned compiler-errors Oct 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2023

fmease commented Oct 3, 2023

View reviewed changes

compiler-errors approved these changes Oct 3, 2023

View reviewed changes

non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound

3f0a327

This comment has been minimized.

Sign in to view

fmease force-pushed the opaq-hid-inf-bnds-non-lt-bndrs branch from 8872857 to 3f0a327 Compare October 3, 2023 12:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023

matthiaskrgr mentioned this pull request Oct 3, 2023

Rollup of 5 pull requests #116384

Merged

bors merged commit 9143370 into rust-lang:master Oct 3, 2023

rustbot added this to the 1.75.0 milestone Oct 3, 2023

fmease deleted the opaq-hid-inf-bnds-non-lt-bndrs branch October 3, 2023 18:34

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Uh oh!

Conversation

fmease commented Oct 3, 2023

Uh oh!

fmease Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

compiler-errors Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

fmease Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

compiler-errors Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

fmease Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

compiler-errors Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

fmease Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

matthiaskrgr commented Oct 3, 2023

Uh oh!

fmease commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented Oct 3, 2023

Uh oh!

bors commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fmease commented Oct 3, 2023 •

edited

Loading