Const stabilize mem::discriminant by dtolnay · Pull Request #116240 · rust-lang/rust

dtolnay · 2023-09-28T17:12:23Z

Tracking issue: #69821.

This PR is a rebase of #103893 to resolve conflicts in library/core/src/lib.rs (against #102470 and #110393).

rustbot · 2023-09-28T17:12:32Z

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

thomcc

The implementation is obviously fine. Feel free to r=me once whatever other work needed to approve this is completed.

dtolnay · 2023-10-28T14:56:56Z

@bors r=thomcc

bors · 2023-10-28T14:56:58Z

📌 Commit fd207e6 has been approved by thomcc

It is now in the queue for this repository.

bors · 2023-10-28T17:12:21Z

⌛ Testing commit fd207e6 with merge 06f9d37...

Const stabilize mem::discriminant Tracking issue: rust-lang#69821. This PR is a rebase of rust-lang#103893 to resolve conflicts in library/core/src/lib.rs (against rust-lang#102470 and rust-lang#110393).

rust-log-analyzer · 2023-10-28T17:41:32Z

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2023-10-28T17:42:03Z

💔 Test failed - checks-actions

dtolnay · 2023-10-28T18:36:03Z

@bors retry

bors · 2023-10-28T19:38:19Z

⌛ Testing commit fd207e6 with merge 7cc36de...

bors · 2023-10-28T21:33:19Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 7cc36de to master...

rust-timer · 2023-10-28T22:55:32Z

Finished benchmarking commit (7cc36de): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-1.2%	[-2.1%, -0.8%]	4
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-2.8%	[-5.5%, -1.1%]	14
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.236s -> 635.482s (0.20%)
Artifact size: 304.41 MiB -> 304.41 MiB (0.00%)

rustbot assigned thomcc Sep 28, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 28, 2023

dtolnay mentioned this pull request Sep 28, 2023

Tracking Issue for const mem::discriminant #69821

Closed

3 tasks

This comment has been minimized.

Sign in to view

thomcc approved these changes Sep 28, 2023

View reviewed changes

Const stabilize mem::discriminant

fd207e6

dtolnay force-pushed the constdiscriminant branch from 4394d10 to fd207e6 Compare September 28, 2023 18:07

dtolnay mentioned this pull request Sep 28, 2023

Const stabilize mem::discriminant #103893

Closed

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 28, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2023

bors merged commit 7cc36de into rust-lang:master Oct 28, 2023

rustbot added this to the 1.75.0 milestone Oct 28, 2023

github-actions Bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

dtolnay deleted the constdiscriminant branch October 31, 2023 13:41

dtolnay removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Const stabilize mem::discriminant#116240

Const stabilize mem::discriminant#116240
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:constdiscriminant

dtolnay commented Sep 28, 2023

Uh oh!

rustbot commented Sep 28, 2023

Uh oh!

This comment has been minimized.

thomcc left a comment

Uh oh!

dtolnay commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

rust-log-analyzer commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

dtolnay commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

rust-timer commented Oct 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

dtolnay commented Sep 28, 2023

Uh oh!

rustbot commented Sep 28, 2023

Uh oh!

This comment has been minimized.

thomcc left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

rust-log-analyzer commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

dtolnay commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

bors commented Oct 28, 2023

Uh oh!

rust-timer commented Oct 28, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants