Skip to content

Use unstable_target_features when checking inline assembly#114467

Merged
bors merged 1 commit intorust-lang:masterfrom
Amanieu:asm-unstable-features
Aug 15, 2023
Merged

Use unstable_target_features when checking inline assembly#114467
bors merged 1 commit intorust-lang:masterfrom
Amanieu:asm-unstable-features

Conversation

@Amanieu
Copy link
Member

@Amanieu Amanieu commented Aug 4, 2023

This is necessary to properly validate register classes even when the relevant target feature name is still unstable.

@Amanieu
Use unstable_target_features when checking inline assembly
a3ab31c 
This is necessary to properly validate register classes even when the
relevant target feature name is still unstable.
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2023

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

@compiler-errors
Copy link
Contributor

compiler-errors commented Aug 4, 2023

Is there a test for this? Or an issue to link?

@Amanieu
Copy link
Member Author

Amanieu commented Aug 7, 2023

This was mostly caught by checking that asm consistently uses unstable_target_features instead of target_features.

The new form is "more correct" since it matches other uses of target features for inline asm checking, but I couldn't figure out an example of where this actually makes a difference in codegen.

@b-naber
Copy link
Contributor

b-naber commented Aug 14, 2023

Does seem reasonable to me, but I'm not sure I fully understand the implications of this change.

r? @oli-obk mabye?

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@b-naber
Copy link
Contributor

b-naber commented Aug 14, 2023

r? compiler

@rustbot rustbot assigned davidtwco and unassigned b-naber Aug 14, 2023
davidtwco
davidtwco approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could add a test for this, but this has been open a while and is a very small change so I'll approve.

@davidtwco
Copy link
Member

davidtwco commented Aug 15, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

📌 Commit a3ab31c has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@bors
Copy link
Collaborator

bors commented Aug 15, 2023

⌛ Testing commit a3ab31c with merge c1699a7...

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing c1699a7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2023
@bors bors merged commit c1699a7 into rust-lang:master Aug 15, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 15, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Aug 15, 2023

Finished benchmarking commit (c1699a7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 -2.3% [-2.7%, -2.0%] 3
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -2.3% [-2.7%, -2.0%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.523s -> 633.856s (0.21%)
Artifact size: 346.66 MiB -> 346.73 MiB (0.02%)

antoyo pushed a commit to antoyo/rust that referenced this pull request Oct 9, 2023
@bors
Auto merge of rust-lang#114467 - Amanieu:asm-unstable-features, r=dav…
afd4e1e 
…idtwco

Use `unstable_target_features` when checking inline assembly

This is necessary to properly validate register classes even when the relevant target feature name is still unstable.
@taiki-e taiki-e mentioned this pull request Nov 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Amanieu @rustbot @compiler-errors @b-naber @davidtwco @bors @rust-timer