Explain more clearly why fn() -> T can't be #[derive(Clone)]
#114029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @scottmcm (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
scottmcm
reviewed
Jul 29, 2023
library/core/src/clone.rs
Outdated
Member
There was a problem hiding this comment.
I don't think "invalid" is a good thing to say here, since that code compiles fine https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=63f01a475d60aa4896f193a3a887044b.
That might not be what you want, but it's not invalid, so I think this section should better elaborate what it's trying to say.
@rustbot author
Member
Author
There was a problem hiding this comment.
Thank you for the feedback! I have now pushed a more fleshed out explanation. Looking forward to your new feedback. Here is how the new version looks when rendered:
@rustbot ready
rustbot
added
S-waiting-on-author
scottmcm
added
T-libs-api
rustbot
added
S-waiting-on-review
Member
|
Thanks, it looks better now. @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 5, 2023
Explain more clearly why `fn() -> T` can't be `#[derive(Clone)]` Closes rust-lang#73480 The derived impls were generated with `rustc -Z unpretty=expanded main.rs` and the raw output is: ```rust struct Generate<T>(fn() -> T); #[automatically_derived] impl<T: ::core::marker::Copy> ::core::marker::Copy for Generate<T> { } #[automatically_derived] impl<T: ::core::clone::Clone> ::core::clone::Clone for Generate<T> { #[inline] fn clone(&self) -> Generate<T> { Generate(::core::clone::Clone::clone(&self.0)) } } ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#114029 (Explain more clearly why `fn() -> T` can't be `#[derive(Clone)]`) - rust-lang#114248 (Make lint missing-copy-implementations honor negative `Copy` impls) - rust-lang#114498 (Print tidy command with bless tidy check failure) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73480
The derived impls were generated with
rustc -Z unpretty=expanded main.rsand the raw output is: