Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] Deny noop_method_call #112160

Closed
wants to merge 3 commits into from
Closed

[experiment] Deny noop_method_call #112160

wants to merge 3 commits into from

Conversation

fee1-dead
Copy link
Member

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 1, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@fee1-dead
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jun 1, 2023

⌛ Trying commit 35a885ef1db28404d5cde4562db6ed2a89610a7c with merge ec0465088c02b2362b63a7667d648316a45195f9...

@fee1-dead fee1-dead mentioned this pull request Jun 1, 2023
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 1, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@fee1-dead
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jun 1, 2023

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout deny-noop-method-call (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self deny-noop-method-call --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message 
Failed to merge submodule src/tools/cargo (not checked out)
Auto-merging src/tools/cargo
CONFLICT (submodule): Merge conflict in src/tools/cargo
Auto-merging compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Auto-merging compiler/rustc_lint/src/lints.rs
Auto-merging compiler/rustc_lint/messages.ftl
Automatic merge failed; fix conflicts and then commit the result.

@fee1-dead fee1-dead force-pushed the deny-noop-method-call branch from 25b1bb1 to 4af4e0f Compare June 1, 2023 11:08
@fee1-dead
Copy link
Member Author

not sure how the submodule thing works, so I'm just going to wait for the submodule bump

@fee1-dead fee1-dead force-pushed the deny-noop-method-call branch from 4af4e0f to 59b2ca3 Compare June 4, 2023 15:06
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-14 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.............ii...........................F...............................

failures:

---- src/noop_method_call.rs - noop_method_call::NOOP_METHOD_CALL (line 16) stdout ----
error: call to `.clone()` on a reference in this situation does nothing
  |
  |
6 | let clone: &Foo = foo.clone();
  |                      ^^^^^^^^ unnecessary method call
  |
  = note: the type `Foo` does not implement `Clone`, so calling `clone` on `&Foo` copies the reference, which does not do anything and can be removed
  = note: `#[deny(noop_method_call)]` on by default
error: aborting due to previous error

Couldn't compile the test.


failures:
    src/noop_method_call.rs - noop_method_call::NOOP_METHOD_CALL (line 16)

test result: FAILED. 71 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out; finished in 3.57s

error: doctest failed, to rerun pass `-p rustc_lint --doc`

@fee1-dead
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jun 5, 2023

⌛ Trying commit 59b2ca3 with merge 024378d9203a4009ed73d6db2681b88a8d74ce7a...

@bors
Copy link
Collaborator

bors commented Jun 5, 2023

☀️ Try build successful - checks-actions
Build commit: 024378d9203a4009ed73d6db2681b88a8d74ce7a (024378d9203a4009ed73d6db2681b88a8d74ce7a)

1 similar comment
@bors
Copy link
Collaborator

bors commented Jun 5, 2023

☀️ Try build successful - checks-actions
Build commit: 024378d9203a4009ed73d6db2681b88a8d74ce7a (024378d9203a4009ed73d6db2681b88a8d74ce7a)

@fee1-dead
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-112160 created and queued.
🤖 Automatically detected try build 024378d9203a4009ed73d6db2681b88a8d74ce7a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-112160 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-112160 is completed!
📊 1712 regressed and 2 fixed (289494 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 6, 2023
@fee1-dead fee1-dead closed this Jul 23, 2023
@fee1-dead fee1-dead deleted the deny-noop-method-call branch July 23, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fee1-dead @rustbot @bors @rust-log-analyzer @craterbot