Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TrustedStep require Copy #112083

Merged
merged 2 commits into from
May 30, 2023
Merged

Make TrustedStep require Copy #112083

merged 2 commits into from
May 30, 2023

Conversation

scottmcm
Copy link
Member

All the implementations of the trait already are Copy, and this seems to be enough to simplify the implementations enough to make the MIR inliner willing to inline basics like Range::next.

r? @thomcc

@scottmcm
Make TrustedStep require Copy
11fa176 
All the implementations of the trait already are `Copy`, and this seems to be enough to simplify the implementations enough to make the MIR inliner willing to inline basics like `Range::next`.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 29, 2023
@thomcc
Copy link
Member

thomcc commented May 29, 2023

Looks nice.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 29, 2023

📌 Commit 11fa176 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Noratrieb
Copy link
Member

@bors r-
test requires blessing

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 29, 2023

The Miri subtree was changed

cc @rust-lang/miri

@scottmcm
Copy link
Member Author

@bors r=thomcc

@bors
Copy link
Collaborator

bors commented May 29, 2023

📌 Commit 50e01f4 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2023
@bors
Copy link
Collaborator

bors commented May 30, 2023

⌛ Testing commit 50e01f4 with merge 578bcbc...

@bors
Copy link
Collaborator

bors commented May 30, 2023

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 578bcbc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 30, 2023
@bors bors merged commit 578bcbc into rust-lang:master May 30, 2023
@rustbot rustbot added this to the 1.72.0 milestone May 30, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (578bcbc): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)		 0.5% [0.2%, 0.7%] 5
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 -1.2% [-3.5%, -0.4%] 13
All ❌✅ (primary) -0.4% [-1.1%, 0.2%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 -4.8% [-5.9%, -2.1%] 5
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)		 -3.0% [-4.0%, -2.1%] 4
All ❌✅ (primary) -1.8% [-1.8%, -1.8%] 1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.8%] 44
Regressions ❌
(secondary)		 0.8% [0.2%, 1.4%] 2
Improvements ✅
(primary)		 -0.1% [-0.4%, -0.0%] 4
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 3
All ❌✅ (primary) 0.1% [-0.4%, 0.8%] 48

Bootstrap: 645.491s -> 642.797s (-0.42%)

@rustbot rustbot added the perf-regression Performance regression. label May 30, 2023
@scottmcm scottmcm deleted the simpler-range-next branch May 30, 2023 16:33
@krtab krtab mentioned this pull request Apr 12, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 16, 2024
@GuillaumeGomez
Rollup merge of rust-lang#123859 - krtab:uneeded_clone, r=cuviper
183c706 
Remove uneeded clones now that TrustedStep implies Copy

This is a follow up to 11fa176 (from rust-lang#112083)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2024
@rust-timer
Unrolled build for rust-lang#123859
b2b284e 
Rollup merge of rust-lang#123859 - krtab:uneeded_clone, r=cuviper

Remove uneeded clones now that TrustedStep implies Copy

This is a follow up to 11fa176 (from rust-lang#112083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
7 participants
@scottmcm @thomcc @bors @rust-log-analyzer @Noratrieb @rustbot @rust-timer