Avoid copy-pasting the ilog panic string in a bunch of places
#107961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#107654 (reword descriptions of the deprecated int modules) - rust-lang#107915 (Add `array::map` benchmarks) - rust-lang#107961 (Avoid copy-pasting the `ilog` panic string in a bunch of places) - rust-lang#107962 (Add a doc note about why `Chain` is not `ExactSizeIterator`) - rust-lang#107966 (Update browser-ui-test version to 0.14.3) - rust-lang#107970 (Hermit: Remove floor symbol) - rust-lang#107973 (Fix unintentional UB in SIMD tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ended up changing the implementations to
if letbecause it doesn't work todue to the
!. But as a bonus that meant I could remove therustc_allow_const_fn_unstabletoo.