Skip to content

fix comment for TokenCursor::desugar #106268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 30, 2022
Merged

fix comment for TokenCursor::desugar #106268

bors merged 1 commit into from
Dec 30, 2022

Conversation

@kraktus
Copy link
Contributor

@kraktus kraktus commented Dec 29, 2022

the hashes of the text were forgotten.

@kraktus
fix comment for TokenCursor::desugar
d08134f 
the hashes of the text were forgotten.
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2022

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2022
@Noratrieb
Copy link
Member

Noratrieb commented Dec 29, 2022

r? Nilstrieb
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 29, 2022

📌 Commit d08134f has been approved by Nilstrieb

It is now in the queue for this repository.

@rustbot rustbot assigned Noratrieb and unassigned davidtwco Dec 29, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2022
@bors
Copy link
Collaborator

bors commented Dec 30, 2022

⌛ Testing commit d08134f with merge e5e5fcb...

@bors
Copy link
Collaborator

bors commented Dec 30, 2022

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing e5e5fcb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2022
@bors bors merged commit e5e5fcb into rust-lang:master Dec 30, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 30, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 30, 2022

Finished benchmarking commit (e5e5fcb): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.5%, -0.2%] 17
Improvements ✅
(secondary)		 -0.3% [-0.7%, -0.2%] 15
All ❌✅ (primary) -0.3% [-0.5%, -0.2%] 17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.6% [-5.7%, -5.4%] 3
All ❌✅ (primary) - - 0

@Noratrieb
Copy link
Member

Noratrieb commented Dec 30, 2022

That's some interesting perf numbers. Just noise/bimodality but very weird that even a comment change would trigger this.

cc @rust-lang/wg-compiler-performance

@rylev rylev mentioned this pull request Jan 3, 2023
Merged
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106268 - kraktus:patch-2, r=Nilstrieb
2dbcbd9 
fix comment for `TokenCursor::desugar`

the hashes of the text were forgotten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Noratrieb Noratrieb

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

6 participants

@kraktus @rustbot @Noratrieb @bors @rust-timer @davidtwco