Skip to content

rewrite shootout-binarytrees.rs to match shootout directives#10145

Merged
bors merged 1 commit into
rust-lang:masterfrom
TeXitoi:issues-2913
Oct 30, 2013
Merged

rewrite shootout-binarytrees.rs to match shootout directives#10145
bors merged 1 commit into
rust-lang:masterfrom
TeXitoi:issues-2913

Conversation

@TeXitoi

@TeXitoi TeXitoi commented Oct 29, 2013

Copy link
Copy Markdown
Contributor

The old version didn't follow shootout's directives: no memory were
deallocated. At the same time, parallelisation of the computation.

fix #2913

The old version didn't follow shootout's directives: no memory were
deallocated.  At the same time, parallelisation of the computation.

fix rust-lang#2913
@TeXitoi

TeXitoi commented Oct 29, 2013

Copy link
Copy Markdown
Contributor Author

Clarification asked on IRC:

  • parallelization is not necessary to fix Fix shootout benchmarks #2913;
  • the parallelization correspond to the one done in the C and C++ version of the shootout, so parallelisation is not needed by the shootout, but allowed;
  • on my 32bits Atom with 1GB ram and 1GB swap, with 10, it fails with a memory error, after the fix, it pass easily.

bors added a commit that referenced this pull request Oct 29, 2013
The old version didn't follow shootout's directives: no memory were
deallocated.  At the same time, parallelisation of the computation.

fix #2913
@bors bors closed this Oct 30, 2013
@bors bors merged commit 4ca32e1 into rust-lang:master Oct 30, 2013
@TeXitoi TeXitoi deleted the issues-2913 branch December 1, 2013 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix shootout benchmarks

3 participants