Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more unicode tests #35442

Closed
sophiajt opened this issue Aug 7, 2016 · 7 comments
Closed

Write more unicode tests #35442

sophiajt opened this issue Aug 7, 2016 · 7 comments
Assignees
Labels
A-Unicode Area: Unicode C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

We had only a couple unicode tests before and it's difficult to see how accurate they were because of how they were testing.

I've since moved the main one to a UI test, which is better, but I think unicode needs to be more thoroughly tested using the new UI mode.

This issue is a todo item to go and add a few more ui tests for various unicode to ensure we've got better coverage.

@Mark-Simulacrum
Copy link
Member

@jonathandturner Could you give an update on this? I presume that not much has been done here, but perhaps we could write up what we want to test with regards to unicode and make it an E-easy bug?

@sophiajt
Copy link
Contributor Author

@Mark-Simulacrum - Quite possibly. Someone who is working in error messages more than I am these days may be able to take this and run with it. The gist is pretty simple, at the time we only had a few unicode tests in the ui directory. I'm not aware of the current state of affairs in the error message testing.

@Mark-Simulacrum
Copy link
Member

Okay, so I think what we need here is a concrete list of things that we should test with regards to Unicode, that is, what edge cases we should make sure work. I can't think of anything concrete right now, though.

@Mark-Simulacrum Mark-Simulacrum added A-Unicode Area: Unicode E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Jun 22, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 25, 2017
@behnam
Copy link
Contributor

behnam commented Aug 11, 2017

@jonathandturner, could you please share more about which area of rustc this is issue is about? Is this about the std_unicode crate, compiler itself, or some other thing?

@sophiajt
Copy link
Contributor Author

@behnam - this was a long time ago, but iirc, the issue was that we only had a handful of unicode tests for the compiler, specifically compile-fail and ui tests.

@czipperz
Copy link
Contributor

czipperz commented Jun 2, 2019

What's the progress here? Is this resolved?

@rylev
Copy link
Member

rylev commented Jun 17, 2021

Triage: I'm going to close this as it's a bit too general IMO to be helpful. There are several unicode related tests in the compiler for cases where unicode characters end up in places they should not be. A quick search of "unicode" in GitHub reveals many of them. We can reopen this issue if we still feel like that cases where unicode edge cases are not being handled, but we should probably include a list of such cases.

cc @estebank as this largely has to do with providing good diagnostics.

@rylev rylev closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Unicode Area: Unicode C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Projects
None yet
Development

No branches or pull requests

5 participants