Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"note: the trait cannot require ..." printed twice for object-safety violations #20692

Closed
huonw opened this issue Jan 7, 2015 · 0 comments
Closed

"note: the trait cannot require ..." printed twice for object-safety violations #20692

huonw opened this issue Jan 7, 2015 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@huonw
Copy link
Member

huonw commented Jan 7, 2015 

trait Array: Sized {}

fn f<T: Array>(x: &T) {
    let _ = x as &Array;
}

fn main() {}
<anon>:4:13: 4:14 error: cannot convert to a trait object because trait `Array` is not object-safe [E0038]
<anon>:4     let _ = x as &Array;
                     ^
<anon>:4:13: 4:14 note: the trait cannot require that `Self : Sized`
<anon>:4     let _ = x as &Array;
                     ^
<anon>:4:13: 4:14 note: the trait cannot require that `Self : Sized`
<anon>:4     let _ = x as &Array;
                     ^

Preferably the note would only be printed once, otherwise it's just a bit confusing.
@huonw huonw added the A-diagnostics Area: Messages for errors, warnings, and lints label Jan 7, 2015
nham pushed a commit to nham/rust that referenced this issue Jun 5, 2015
Only report Self: Sized violation once.
3acfe03 
Fixes rust-lang#20692.
@nham nham mentioned this issue Jun 5, 2015
Closed
nham pushed a commit to nham/rust that referenced this issue Jun 12, 2015
Only report Self: Sized violation once.
c7d26a9 
Fixes rust-lang#20692.
nham pushed a commit to nham/rust that referenced this issue Jun 12, 2015
Add test for fix of rust-lang#20692
40088fb
@tyoc213 tyoc213 mentioned this issue Aug 30, 2015
Closed
brson pushed a commit to brson/rust that referenced this issue Oct 16, 2015
@brson
show each object-safety violation once
fc166d4 
different supertraits can suffer from the same object-safety violation,
leading to duplication in the error message. Avoid it.

Fixes rust-lang#20692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only report Self: Sized violation once. nham/rust
1 participant
@huonw