-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Stabilize dyn Allocator #156906
Copy link
Copy link
Closed
Labels
A-allocatorsArea: Custom and system allocatorsArea: Custom and system allocatorsA-dyn-compatibilityArea: Dyn compatibility (formerly: object safety)Area: Dyn compatibility (formerly: object safety)S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.Status: Awaiting review from the assignee but also interested parties.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.
Description
Metadata
Metadata
Assignees
Labels
A-allocatorsArea: Custom and system allocatorsArea: Custom and system allocatorsA-dyn-compatibilityArea: Dyn compatibility (formerly: object safety)Area: Dyn compatibility (formerly: object safety)S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.Status: Awaiting review from the assignee but also interested parties.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.
View all comments
PR #156882 is stabilizing
Allocator.In order to do so more easily, it's marking
Allocatoras notdyn-compatible, to reserve the options of either adding features that currently preventdyn-compatibility or marking itdyn-compatible and requiring those features to use an extension trait instead.In order to make this decision and the stabilization decision in parallel, I'm filing this issue for a separate FCP.
Based on the discussion in the All Hands, it seemed like there weren't any features that we couldn't do via the extension trait solution, allowing the base trait to be
dyn-compatible. So, in this issue, I'm proposing that we remove the limitation onAllocatorand allowdyn Allocator.