-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Missing #[must_use] attribute for many float functions #154854
Copy link
Copy link
Closed
Labels
A-floating-pointArea: Floating point numbers and arithmeticArea: Floating point numbers and arithmeticC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-floating-pointArea: Floating point numbers and arithmeticArea: Floating point numbers and arithmeticC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The following floating point functions seems to be missing a
#[must_use]attribute:It seems like that the other floating point functions have one of the following reasons:
Edit: This original mentioned 13 functions, but there is actually only 5 functions without the attribute, so the list has been updated. (tyilo/std-traits@e012d28)