-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
MGCA: Avoid code duplication between HIR ty lowering and elsewhere #150621
Copy link
Copy link
Open
Labels
A-HIR-ty-loweringArea: HIR ty lowering (HIR → middle::ty IR)Area: HIR ty lowering (HIR → middle::ty IR)A-technical-debtArea: Internal cleanup workArea: Internal cleanup workC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-needs-designThis issue needs exploration and design to see how and if we can fix/implement itThis issue needs exploration and design to see how and if we can fix/implement itF-min_generic_const_args`#![feature(min_generic_const_args)]``#![feature(min_generic_const_args)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-HIR-ty-loweringArea: HIR ty lowering (HIR → middle::ty IR)Area: HIR ty lowering (HIR → middle::ty IR)A-technical-debtArea: Internal cleanup workArea: Internal cleanup workC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-needs-designThis issue needs exploration and design to see how and if we can fix/implement itThis issue needs exploration and design to see how and if we can fix/implement itF-min_generic_const_args`#![feature(min_generic_const_args)]``#![feature(min_generic_const_args)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Currently the HIR ty lowering logic for direct const arguments has a lot of overlap with code elsewhere in the compiler. For example:
I'm not sure what the right way to avoid this code duplication is, but we should fix this before this code duplication becomes something that affects stable code.