-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
fn compute_closure_requirements_modulo_opaques shouldn't clone all its inputs #146079
Copy link
Copy link
Open
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
#145925 added
fn compute_closure_requirements_modulo_opaqueswhich clones a bunch of borrowck state to be able to compute the propagated closure requirements for nested bodies without actually finishing borowck for it.We should change the code to take at least some of the fields by reference/
Rcinstead of just cloning everything. See the relevantFIXME(#146079)in the source