-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
#133492 changed PathSet matching to also admit path prefixes, in addition to the previously-admitted suffixes. Unfortunately, this breaks how describe! handles some Steps. For the typical non-ShouldRun::suite_path Step, it will consume a path filter like "compiler" when eligible.
#133492 allowing prefix matching changed which Steps is permitted to "eat" the path filter first, which broke ./x test compiler --stage 0 and ./x build compiler --stage 0 due to the respective Step registration order and which Steps get to consume the path filter first:
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)