-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Fix argument splitting in compiletest #132599
Copy link
Copy link
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-bugCategory: This is a bug.Category: This is a bug.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-bugCategory: This is a bug.Category: This is a bug.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for Bug.
We should fix how arguments are split in compiletest, this involves multiple places:
//@ compile-flagsand suchThey usually involve converting from a user-provided escaped string to
Command::new()andCommand::argand such, but yeah. Command arg splitting in compiletest is currently very naive and usually just splits on whitespace or is otherwise very basic, we should probably just use a proper library to handle the splitting...