Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for const_copy_from_slice #131415

Closed
1 of 3 tasks
okaneco opened this issue Oct 8, 2024 · 6 comments · Fixed by #138098
Closed
1 of 3 tasks

Tracking Issue for const_copy_from_slice #131415

okaneco opened this issue Oct 8, 2024 · 6 comments · Fixed by #138098
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Comments

@okaneco
Copy link
Contributor

okaneco commented Oct 8, 2024 •
edited
Loading

Feature gate: #![feature(const_copy_from_slice)]

This is a tracking issue for using <[T]>::copy_from_slice in const.

Public API

impl<T> [T] {
    pub const fn copy_from_slice(&mut self, src: &[T])
    where
        T: Copy;
}

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
@okaneco okaneco added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 8, 2024
@okaneco okaneco mentioned this issue Oct 8, 2024
Merged
@bjoernager

This comment has been minimized.

Sign in to view
jhpratt added a commit to jhpratt/rust that referenced this issue Dec 2, 2024
@jhpratt
Rollup merge of rust-lang#131416 - okaneco:const_copy, r=RalfJung
cb67512 
Mark `slice::copy_from_slice` unstably const

Tracking issue rust-lang#131415

I used `const_eval_select` for runtime and const panic functions because const formatting isn't available yet.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 2, 2024
@rust-timer
Unrolled build for rust-lang#131416
31144e8 
Rollup merge of rust-lang#131416 - okaneco:const_copy, r=RalfJung

Mark `slice::copy_from_slice` unstably const

Tracking issue rust-lang#131415

I used `const_eval_select` for runtime and const panic functions because const formatting isn't available yet.
@RalfJung
Copy link
Member

@rust-lang/libs-api @rust-lang/wg-const-eval this function has been stable since Rust 1.9, and can be fully implemented using already-const-stable facilities (largely, ptr::copy_nonoverlapping). I would say it is ready for const-stabilization. :)

impl<T> [T] {
    pub const fn copy_from_slice(&mut self, src: &[T])
    where
        T: Copy;
}

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Feb 24, 2025
@dtolnay
Copy link
Member

dtolnay commented Feb 24, 2025

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 24, 2025 •
edited by BurntSushi
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 24, 2025
@dtolnay dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Feb 24, 2025
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 24, 2025
@rfcbot
Copy link

rfcbot commented Feb 24, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 24, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 6, 2025
@rfcbot
Copy link

rfcbot commented Mar 6, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this issue Mar 6, 2025
Open
@okaneco okaneco mentioned this issue Mar 6, 2025
Merged
@RalfJung RalfJung mentioned this issue Mar 6, 2025
Merged
@bors bors closed this as completed in 33985ce Mar 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#138098
d4139af 
Rollup merge of rust-lang#138098 - okaneco:stabilize_const_copy_from_slice, r=tgross35

Stabilize feature `const_copy_from_slice`

Stabilizes `copy_from_slice` method on `[T]`

FCP completed rust-lang#131415 (comment)
Closes rust-lang#131415
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this issue Mar 11, 2025
@jhpratt
Rollup merge of rust-lang#131416 - okaneco:const_copy, r=RalfJung
7b70200 
Mark `slice::copy_from_slice` unstably const

Tracking issue rust-lang#131415

I used `const_eval_select` for runtime and const panic functions because const formatting isn't available yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize feature const_copy_from_slice okaneco/rust
5 participants
@RalfJung @dtolnay @rfcbot @okaneco @bjoernager