-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discussion] ErrorKind::InvalidFilename
from io_error_more
#130192
Comments
"This error can also cause if..." is, indeed, improper English. "Cause" is a transitive verb. It can be rephrased in the passive voice as "This error can be caused if...". |
Alternative rephrasing: "This error can also occur if ..." |
I'm going to propose that we stabilize this as @rfcbot merge |
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
…boet Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang#130192 (comment) Tracking issues: rust-lang#86442 & rust-lang#130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang#86442 (comment)). This can presumably be addressed later.
…boet Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang#130192 (comment) Tracking issues: rust-lang#86442 & rust-lang#130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang#86442 (comment)). This can presumably be addressed later.
…boet Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang#130192 (comment) Tracking issues: rust-lang#86442 & rust-lang#130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang#86442 (comment)). This can presumably be addressed later.
Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang/rust#130192 (comment) Tracking issues: #86442 & #130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang/rust#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang/rust#86442 (comment)). This can presumably be addressed later.
Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang/rust#130192 (comment) Tracking issues: #86442 & #130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang/rust#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang/rust#86442 (comment)). This can presumably be addressed later.
…boet Stabilize `std::io::ErrorKind::InvalidFilename` FCP complete: rust-lang#130192 (comment) Tracking issues: rust-lang#86442 & rust-lang#130192 This PR: - Stabilizes `InvalidFilename` without changing its name to `InvalidFileName`. - Fixes the doc comment (rust-lang#130192 (comment)) - Does not separate "the name is too long" case into a separate `ErrorKind`. That case is currently documented to be covered by `InvalidFilename` in the doc. I'm not sure if it would be possible to change this later or if that would be an unacceptable breaking change. - Does not map more raw OS errors to this `ErrorKind` (as suggested in rust-lang#86442 (comment)). This can presumably be addressed later.
@rustbot label C-discussion
Main tracking issue: #86442
Background
The
io_error_more
feature introduced 21 new variants intoErrorKind
. They were FCP'd back in December 2022, but there appeared to be quite a lot of disagreement about 4 of the added variants, so the stabilization (#106375) got stalled for over twenty months. Thankfully, the 17 uncontroversial variants got stabilized in #128316, so now we just need to iron out a satisfactory design for the remaining 4 variants, and then they can be stabilized too.In order to not block any of the remaining variants on each other and to not intertwine the discussions, I've created 4 separate issues, which summarize the concerns & suggestions voiced up until this point and can serve as a place for further discussion.
FilesystemLoop
: [discussion]ErrorKind::FilesystemLoop
fromio_error_more
#130188FilesystemQuotaExceeded
: [discussion]ErrorKind::FilesystemQuotaExceeded
fromio_error_more
#130190CrossesDevices
: [discussion]ErrorKind::CrossesDevices
fromio_error_more
#130191InvalidFilename
: you are hereInvalidFilename
Currently corresponds to
ENAMETOOLONG
on Unix,ERROR_FILENAME_EXCED_RANGE
&ERROR_INVALID_NAME
on Windows. (#86442 (comment))Current docs description:
Docs
I'm not sure "This error can also cause if it exceeded the filename length limit." is well-formed coherent English, but I'm not a native speaker.
Name capitalization
Originally posted by Kornel in #79965 (comment)
Separate "the name is too long" case
Originally posted by cktkw in #86442 (comment)
There is a long reply from Aritz Beobide-Cardinal in #106375 (comment) arguing against the separation.
Map more raw os errors to this
ErrorKind
Originally posted by cktkw in #86442 (comment)
The text was updated successfully, but these errors were encountered: